Capgemini / dcx-react-library

React Library UI/UX agnostic
https://main--6069a6f47f4b9f002171f8e1.chromatic.com
MIT License
107 stars 7 forks source link

Form input props wrong typing and expose input ref #626

Closed jgonza16 closed 2 months ago

jgonza16 commented 2 months ago

Describe the bug when you want use form input with useForm library for example no work because this library need input ref to handle inputs and if you use formInputProps typescript lint throw errors an we has css problems with label because value prop is not handle with state and no update to dcx-form-input--filled. The placeholder has't tokens to change color anda font-sizes

To Reproduce Steps to reproduce the behavior:

  1. try use formInput handle ref way or spread React.HTMLAttributes into inputProps

Expected behavior No linter errros and use input native ref

Screenshots

Desktop (please complete the following information):

image

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

daniele-zurico commented 2 months ago

closed by https://github.com/Capgemini/dcx-react-library/pull/627