Closed Ibabalola closed 4 weeks ago
Can you please also update the story to say that this feature has been added / how it works
Hi @alexwbbr , the change made here is internal, with the additional props added on the type TabContextProps
which is for the TabContext.Provider
therefore we have not exposed any new properties for the end consumer therefore I'm not how beneficial a story would be here.
The change made is simply to allow keyboard only users to be able to switch to the inactive tabs via keyboard controls
How would dev's know that the component has this functionality unless they read the change log then? I still think it should be mentioned somewhere that this has been added to the component
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
a687501
) to head (7a4e34b
).
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
How would dev's know that the component has this functionality unless they read the change log then? I still think it should be mentioned somewhere that this has been added to the component
added a keyboard event story @alexwbbr.
// 'Left', 'Right', 'Up' and 'Down' event listeners added for
<Tab />