Capgemini / dcx-react-library

React Library UI/UX agnostic
https://main--6069a6f47f4b9f002171f8e1.chromatic.com
MIT License
107 stars 7 forks source link

feat: adding keydown event listeners for tabs #659

Closed Ibabalola closed 4 weeks ago

Ibabalola commented 4 weeks ago

// 'Left', 'Right', 'Up' and 'Down' event listeners added for <Tab />

Ibabalola commented 4 weeks ago

Can you please also update the story to say that this feature has been added / how it works

Hi @alexwbbr , the change made here is internal, with the additional props added on the type TabContextProps which is for the TabContext.Provider therefore we have not exposed any new properties for the end consumer therefore I'm not how beneficial a story would be here.

The change made is simply to allow keyboard only users to be able to switch to the inactive tabs via keyboard controls

alexwbbr commented 4 weeks ago

How would dev's know that the component has this functionality unless they read the change log then? I still think it should be mentioned somewhere that this has been added to the component

codecov-commenter commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (a687501) to head (7a4e34b).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/1.1.0 #659 +/- ## =============================================== Coverage 100.00% 100.00% =============================================== Files 85 85 Lines 1553 1580 +27 Branches 539 555 +16 =============================================== + Hits 1553 1580 +27 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Ibabalola commented 4 weeks ago

How would dev's know that the component has this functionality unless they read the change log then? I still think it should be mentioned somewhere that this has been added to the component

added a keyboard event story @alexwbbr.