search

Capgemini / dcx-react-library

React Library UI/UX agnostic
https://main--6069a6f47f4b9f002171f8e1.chromatic.com
MIT License
113 stars 6 forks source link

Accordion - closes when accordion item is clicked #660

Closed szilvihorvath closed 3 months ago

szilvihorvath commented 4 months ago

Describe the bug When an accordion item is expanded and the item's details is clicked, the accordion item closes.

To Reproduce Steps to reproduce the behavior:

  1. Open an accordion section
  2. Click on the accordion details (not the accordion title)
  3. The accorion section will close

Expected behavior The accordion item should only close when the accordion title is clicked.

Desktop (please complete the following information):

Additional context The Accordion has an onClick function that is passed down to each accordion item including the AccordionDetails, so when you click on any part of an accordion item, it closes the item.

Please follow these steps to create your branch:

git checkout release/1.1.0
git pull
git checkout -b 'fix/accordion-click-event'
alexsteele95 commented 4 months ago

Now looking into this!

alexsteele95 commented 4 months ago

Should be fixed by: https://github.com/Capgemini/dcx-react-library/pull/665 cc: @szilvihorvath @daniele-zurico

daniele-zurico commented 3 months ago

Closed by #665