search

Capgemini / kubeform

Form your :boat: Kubernetes :anchor: cluster anywhere using CoreOS, Terraform and Ansible
https://capgemini.github.io/kubeform
MIT License
326 stars 57 forks source link

Full support for terraform-0.7.11 #171

Closed tamsky closed 7 years ago

tamsky commented 7 years ago

terraform apply (and destroy) works mostly clean now.

Later steps in the docs, like ansible-playbook doesn't apply cleanly, but I think that's beyond the scope of this PR.

After https://github.com/Capgemini/tf_tls/pull/45 lands, we can fix the module references s@github.com/tamsky@github.com/Capgemini@g

builds from changes in https://github.com/Capgemini/kubeform/pull/170

enxebre commented 7 years ago

hey @tamsky @mrwacky42 thanks a lot for this, I just dropped a few comments.

tamsky commented 7 years ago

@enxebre do you have an opinion on whether I should include @methril 's Digital Ocean terraform 0.7.x changes that he's offering in https://github.com/tamsky/kubeform/pull/1 ?

enxebre commented 7 years ago

hey @tamsky let's create a different PR for DigitalOcean. I just dropped a new comment on the etc discovery manual step but otherwise looks good to me. So Then If we can squash the git history to keep it cleaner I'm more than happy to merge. Thanks a lot for your contributions

tamsky commented 7 years ago

I guess I don't know the proper way to squash a PR referencing a remote repo. I deleted my branch and pushed a new commit with the same branch name.

What's the correct way?