Capgemini / mesos-ui

An alternative web UI for Apache Mesos, built with :heart: and React.JS
http://capgemini.github.io/devops/mesos-ui
MIT License
220 stars 48 forks source link

ZOOKEEPER_ADDRESS should accept domain names too #94

Closed jeacott1 closed 8 years ago

jeacott1 commented 8 years ago

just wasted ages trying to figure out why this wouldn't start. this works:

ZOOKEEPER_ADDRESS="ip1:2181,ip2:2181,ip3:2181"

this doesn't, but should!

ZOOKEEPER_ADDRESS="some_domain_that_resolves_to_an_ip:2181"
rhoml commented 8 years ago

This is accepted at the moment. We are running it using our Consul DNS for zookeeper ZOOKEEPER_ADDRESS=prod.zookeeper.service.xxxx.consul:2181

enxebre commented 8 years ago

yep, It will resolve whatever is resolvable and will reach whatever is reachable from inside the container. @rhoml it'd be nice if you can create a PR adding the name of your company to the list in the readme thanks!

rhoml commented 8 years ago

So I think that this issue can be closed