search

Capgemini / xrm-datamigration-xrmtoolbox

Export and import data for Microsoft Dataverse as an XrmToolBox plugin. Supports JSON and CSV.
MIT License
8 stars 4 forks source link

ci: release to Nuget #30

Closed tdashworth closed 3 years ago

tdashworth commented 3 years ago

update pipeline to align with our best practices

tdashworth commented 3 years ago

@ewingjm Any idea why this is failing? I switched the restore from Nuget to DotNet. Should I just revert that? 

##[error]Capgemini.Xrm.CdsDataMigrator\Capgemini.Xrm.CdsDataMigratorLibrary.Tests.Unit\Capgemini.Xrm.CdsDataMigratorLibrary.Tests.Unit.csproj(339,5): Error : This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them.  For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is ..\..\packages\Microsoft.CodeAnalysis.VersionCheckAnalyzer.2.9.8\build\Microsoft.CodeAnalysis.VersionCheckAnalyzer.props.
Project "D:\a\1\s\Capgemini.Xrm.CdsDataMigrator\Capgemini.Xrm.CdsDataMigrator.sln" (1) is building "D:\a\1\s\Capgemini.Xrm.CdsDataMigrator\Capgemini.Xrm.CdsDataMigratorLibrary.Tests.Unit\Capgemini.Xrm.CdsDataMigratorLibrary.Tests.Unit.csproj" (2) on node 1 (default targets).
D:\a\1\s\Capgemini.Xrm.CdsDataMigrator\Capgemini.Xrm.CdsDataMigratorLibrary.Tests.Unit\Capgemini.Xrm.CdsDataMigratorLibrary.Tests.Unit.csproj(339,5): error : This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them.  For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is ..\..\packages\Microsoft.CodeAnalysis.VersionCheckAnalyzer.2.9.8\build\Microsoft.CodeAnalysis.VersionCheckAnalyzer.props.
realekhor commented 3 years ago

@tdashworth i will fix this

tdashworth commented 3 years ago

I have added a tag for the last release to NuGet. Not sure if that will reset GitVersion to v1.0.6. @ewingjm?

tdashworth commented 3 years ago

Do we need to add this to update the assembly version as well? Not just the NuGet package version?

ewingjm commented 3 years ago

Do we need to add this to update the assembly version as well? Not just the NuGet package version?

Shouldn't need to as it's already handled by the GitVersion task in the pipeline. Updating the assembly version is configurable in the task. I'm guessing it needs to be set to true given that this is a plug-in.

ewingjm commented 3 years ago

I have added a tag for the last release to NuGet. Not sure if that will reset GitVersion to v1.0.6. @ewingjm?

You'll need to tag the latest commit on the master branch for whatever the current version is.

tdashworth commented 3 years ago

I have added a tag for the last release to NuGet. Not sure if that will reset GitVersion to v1.0.6. @ewingjm?

You'll need to tag the latest commit on the master branch for whatever the current version is.

Do we want to start on a new version? e.g. v1.1.0?

ewingjm commented 3 years ago

I have added a tag for the last release to NuGet. Not sure if that will reset GitVersion to v1.0.6. @ewingjm?

You'll need to tag the latest commit on the master branch for whatever the current version is.

Do we want to start on a new version? e.g. v1.1.0?

if you tag a commit with a version that isn't on NuGet then we'll effectively skip a version. Whichever commit is currently deployed to NuGet should be tagged with a matching version. When the PR is merged, it'll use the commit message to apply the next version on top of this. Putting +semver: minor in the squash commit message should be enough if the current version was tagged.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information