search

Capgemini / xrm-datamigration-xrmtoolbox

Export and import data for Microsoft Dataverse as an XrmToolBox plugin. Supports JSON and CSV.
MIT License
8 stars 4 forks source link

fix: support changing of log level within the tool #44

Closed realekhor closed 2 years ago

tdashworth commented 2 years ago

@realekhor thanks for this. Happy to review this in a few days.

realekhor commented 2 years ago

thanks @tdashworth

tdashworth commented 2 years ago

@realekhor Could the selection box be moved the to final page?

image

realekhor commented 2 years ago

@tdashworth good point. I will try make the change.

realekhor commented 2 years ago

@tdashworth controls now moved to requested pages. hope this is ok.

realekhor commented 2 years ago

@tdashworth looks like i need to add more code coverage tests :(

realekhor commented 2 years ago

@tdashworth not sure we ever went beyond 75% coverage :). so i think it is ready

tdashworth commented 2 years ago

@tdashworth not sure we ever went beyond 75% coverage :). so i think it is ready

Agreed, our code coverage isn't as high as we'd like. Please could we add tests for these two lines:

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

98.1% 98.1% Coverage
0.0% 0.0% Duplication

tdashworth commented 2 years ago

@realekhor Thank you so much for the work you've put into this. It's very much appreciated!