search

Capgemini / xrm-datamigration-xrmtoolbox

Export and import data for Microsoft Dataverse as an XrmToolBox plugin. Supports JSON and CSV.
MIT License
8 stars 4 forks source link

Refactor/import page #66

Closed danroche10 closed 2 years ago

danroche10 commented 2 years ago

This PR aims to refactor the import page so that it:

follows a testable MVP pattern is responsive in design moves away the wizard UX

tdashworth commented 2 years ago

Looking really good so far Dan, thanks for all the effort! A few comments for you and one general testing one.

Could the test names be consistent? I noticed some have _ before the When and others don't. Either is fine, I'm just being OCD 😋

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

82.2% 82.2% Coverage
0.0% 0.0% Duplication

danroche10 commented 2 years ago

Looking really good so far Dan, thanks for all the effort! A few comments for you and one general testing one.

Could the test names be consistent? I noticed some have _ before the When and others don't. Either is fine, I'm just being OCD 😋

Thanks Tom! I've implemented requested changes