search

Capgemini / xrm-datamigration-xrmtoolbox

Export and import data for Microsoft Dataverse as an XrmToolBox plugin. Supports JSON and CSV.
MIT License
8 stars 4 forks source link

Export lookups testing and loading configs #74

Closed danroche10 closed 2 years ago

danroche10 commented 2 years ago

Hey @danroche10,

Thanks for all the time you've put into this.

Quite a few comments for you but most are asking for your opinion.

As you know I'm on leave but will take a look as and when I have time 😀

Comments all make sense. One question re the Helper methods..

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

92.7% 92.7% Coverage
0.0% 0.0% Duplication

danroche10 commented 2 years ago

Hey @danroche10, Thanks for all the time you've put into this. Quite a few comments for you but most are asking for your opinion. As you know I'm on leave but will take a look as and when I have time 😀

Comments all make sense. One question re the Helper methods..

Hey @tdashworth - I've made all requested changes apart from the DataverseEnvironmentSelector change. I have instead suggested we address this in the PR where we look at the Services.