search

Capgemini / xrm-datamigration

Export and import data for Microsoft Dataverse. Supports JSON and CSV.
MIT License
24 stars 11 forks source link

No warning/error if data file can't be found #58

Open vishnushukla opened 3 years ago

vishnushukla commented 3 years ago

I was trying to import JSON files using the Dynamics 365: Data Importer Release task. My file name was starting with the prefix "ExtractedData". It was neither importing file nor giving an error message/warning. Below is the log of import task

image

When I tried to import the same file with ExtractedData prefix using CDS data migrater import xrm toolbox it worked. Later, I changed the filename prefix to "ExportedData" and it worked from "Dynamics 365: Data Importer Release task". We should handle this and give an appropriate error message/ warning like No file found something like that.

tdashworth commented 3 years ago

Thanks for raising this @vishnushukla. I feel this issue is best placed in the engine itself rather than the ADO release task which is just an interface to it. I'll transfer the issue.

tdashworth commented 3 years ago

@vishnushukla Can you provide a zip of the config files and data you were using? Please try to keep the same file structure and also provide a full log from ADO.

I have been looking at the code and it should have logged out a message if there was no file.

Many thanks

tdashworth commented 3 years ago

Ah! Since there are no files it doesn't log anything because string.empty is returned.

https://www.github.com/Capgemini/xrm-datamigration/tree/master/src%2FCapgemini.Xrm.DataMigration.FileStore%2FDataStore%2FDataFileStoreReader.cs