Capgemini / xrm-datamigration

Export and import data for Microsoft Dataverse. Supports JSON and CSV.
MIT License
24 stars 11 forks source link

fix: unable to map to some pass one references #60

Closed ewingjm closed 3 years ago

ewingjm commented 3 years ago

The caching applied in https://github.com/Capgemini/xrm-datamigration/commit/b2381c76a4feeb7cd275aed6b0fb5885177fe107 introduced a potentially breaking change for data imports where the alias mapping caches an empty GUID in pass zero for a record that gets created in pass zero. Pass one would then not be able to map to these records as a result of the cached empty GUID.

This change reverts that breaking change at the cost of worst case mapping failure scenarios being about as performant as they were previously.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication