search

Caphyon / clang-format-editor

Clang-Format Editor is a tool that helps you find the best Clang-Format Style for your C++, C#, Java, JavaScript, and Objective-C code.
https://clangpowertools.com/clang-format-editor.html
Apache License 2.0
44 stars 8 forks source link

Crash when input lines exceeded max padding #14

Closed DaPa closed 3 years ago

DaPa commented 3 years ago

Nice app, thanks for it!

I got a crash when some lines exceeded 600 chars or so: then I tried a quick fix into https://github.com/DaPa/clang-format-editor/commit/b511cd2eab8330bd29df7fda48090b1dba41656a

Then I also made a change to avoid padding, as I saw it unnecessary (just my taste) so instead I opted to trim ending white spaces (https://github.com/DaPa/clang-format-editor/commit/3e170ed98a08eeda568656e93ff04f38f4117085): but not sure if there are side effects (not sure if this padding is required in certain scenarios).

hprica commented 3 years ago

Hello @DaPa,

Thank you for using the app and for your feedback. We'll look into the issue as soon as possible.

If you have any feature suggestions, please let me know.

hprica commented 3 years ago

Fixed in #15