Caphyon / clang-power-tools

Bringing clang-tidy magic to Visual Studio C++ developers.
http://www.clangpowertools.com
Apache License 2.0
472 stars 57 forks source link

Error while running clang-format #1327

Closed SinaKarvandi closed 9 months ago

SinaKarvandi commented 9 months ago

Hi, Thank you for writing this great tool!

Today, Visual Studio automatically updated my clang-power-tools plugin, and now when I try to save the files (using CTRL+C), the following error happens.

Please let me know if you need more information about reproducing this bug.

image

The previous version doesn't have this issue. (I didn't change my format file)

mariru27 commented 9 months ago

Hi @SinaKarvandi,

Thank you for opening this issue, we are here to help you It might be a problem from clang-format.exe v17.0.1 that I can't reproduce

Can you send me your .clang-format file?

Kind regards, Marina

SinaKarvandi commented 9 months ago

Thank you for your quick response.

The problematic .clang-format file is this: https://github.com/HyperDbg/HyperDbg/blob/master/hyperdbg/.clang-format

For now, I fixed the problem by removing two lines of code in the about .clang-format and the updated (fixed) version is this: https://github.com/HyperDbg/HyperDbg/blob/mem-trap/hyperdbg/.clang-format

I agree with you that the error might be for "clang-format.exe". But, as I see the previous versions that have worked for me for years don't have this issue, I just wonder whether anything goes wrong with parameters that clang-power-tools pass to "clang-format.exe".

BTW, everything is fine for me with those modifications.

Thanks again for empowering developers with your great tool!

mariru27 commented 9 months ago

Even with .clang-format file I still can't reproduce the problem

If several users encounter this issue, we will release an update and revert to the previous version of clang-format

It should not be a problem in the way we pass parameters, because we just let clang-format.exe to know about -file option (to use .clang-format) and the tool (clang-format.exe) does all the work

:star: I am glad to hear that you found a workaround, and thank you for reporting this issue @SinaKarvandi. If a newer version from LLVM will fix the problem, we will make immediately a release

Kind regards, Marina