Capitains / HookTest

Testing script for Hook
Mozilla Public License 2.0
3 stars 3 forks source link

Test passes but texts are not exported to release ? #114

Open PonteIneptique opened 7 years ago

PonteIneptique commented 7 years ago

On https://github.com/PerseusDL/canonical-latinLit phi1017.phi015 passes all tests :

https://travis-ci.org/PerseusDL/canonical-latinLit/builds/278749515#L3461

but is not contained in the release :

https://travis-ci.org/PerseusDL/canonical-latinLit/builds/278749515#L6396-L6400

I have few that could share the same issue :

+    +    urn:cts:latinLit:phi0472.phi001.perseus-lat2 was not found in the corpus but is annotated
+    +    urn:cts:latinLit:phi1017.phi015.perseus-lat2 was not found in the corpus but is annotated
+    +    urn:cts:latinLit:phi0119.phi001.perseus-lat2 was not found in the corpus but is annotated
+    +    urn:cts:latinLit:phi0474.phi035.perseus-lat1 was not found in the corpus but is annotated
+    +    urn:cts:latinLit:phi0917.phi001.perseus-lat2 was not found in the corpus but is annotated
PonteIneptique commented 7 years ago

Could you have a look @sonofmun ?

sonofmun commented 7 years ago

I will take a look at it when I get a chance.

sonofmun commented 6 years ago

@PonteIneptique What is the status of this issue? Were these perhaps texts that had empty references and thus were not parsable even though they passed Hook? Or is the problem somewhere else?

PonteIneptique commented 6 years ago

I have never chased down this issue unfortunately. It should definitely be checked :)

sonofmun commented 6 years ago

The question is whether they error now that Hook checks for empty refs. This was the type of problem that led me to recognize the problem with Hook.

PonteIneptique commented 6 years ago

We should have a check on this. I probably won't have time for it this week though .