Capitains / HookTest

Testing script for Hook
Mozilla Public License 2.0
3 stars 3 forks source link

Added validators install to setup.py #134

Closed sonofmun closed 6 years ago

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 95.698% when pulling 5da75368b2b8fcfc6daf8185ab40afd12ac723e0 on setup_correction into d91298d845603482fd6d345b2bb95dd1a7a24322 on master.

PonteIneptique commented 6 years ago

I would like to avoid this issue in the future. Can we have our requirements like this :

package

and our setup.py like this

with open(path.join(here, 'requirements.txt'), encoding='utf-8') as f:
    install_requires, tests_require = [], []
    now_we_have_dev = False
    for line in f:
        if line.startswith("#"):
             if "test" in line:
                   now_we_have_dev = True
        elif now_we_have_dev:
            tests_require.append(line.strip())
        else:
            install_requires.append(line.strip())

# ...
    install_requires=install_requires,
    tests_require=tests_require,

?

PonteIneptique commented 6 years ago

BTW, Not sure GitPython is required.

sonofmun commented 6 years ago

And then requirements.py would look like this?:

MyCapytain>=2.0.0
jingtrang==0.1.1
GitPython==2.1.0
requests>=2.8.1
prettytable==0.7.2
ansicolors==1.0.2
validators==0.12.2
#test
six>=1.10.0
mock==1.3.0
PonteIneptique commented 6 years ago

Yup

sonofmun commented 6 years ago

That works. Will add it here.

PonteIneptique commented 6 years ago

I'll let you merge and release ?

sonofmun commented 6 years ago

Will do.