Fixed #139 : `--scheme ignore` works again

Capitains / HookTest

Testing script for Hook

Mozilla Public License 2.0

3 stars 3 forks source link

Fixed #139 : `--scheme ignore` works again #140

Closed PonteIneptique closed 5 years ago

PonteIneptique commented 5 years ago

Added ability to do HOOKTEST_DEBUG=True for printing more information during run.

coveralls commented 5 years ago

Coverage decreased (-0.08%) to 95.706% when pulling 2ef7c4f50dd885eee033b447882e9e9e1744b220 on issue-139 into cc253b687615e769b431cf8ac2c5b013753a967b on master.

coveralls commented 5 years ago

Coverage decreased (-0.08%) to 95.706% when pulling 2ef7c4f50dd885eee033b447882e9e9e1744b220 on issue-139 into cc253b687615e769b431cf8ac2c5b013753a967b on master.

sonofmun commented 5 years ago

I don't know how important it is to unit test the two new lines that are not being tested (i.e., the print statements): https://github.com/Capitains/HookTest/blob/2ef7c4f50dd885eee033b447882e9e9e1744b220/HookTest/capitains_units/cts.py#L731-L732 and https://github.com/Capitains/HookTest/blob/2ef7c4f50dd885eee033b447882e9e9e1744b220/HookTest/capitains_units/cts.py#L738-L739

PonteIneptique commented 5 years ago

I did not want to test them because it's really there for debugging purpose :)

sonofmun commented 5 years ago

Good. Then I will approve.