Capitains / HookTest

Testing script for Hook
Mozilla Public License 2.0
3 stars 3 forks source link

Should HookTest check for XML declarations #78

Closed sonofmun closed 6 years ago

sonofmun commented 7 years ago

I accidentally removed all the xml declaration from csel-dev, i.e.,

<?xml version="1.0" encoding="UTF-8"?>
<?xml-model href="http://www.stoa.org/epidoc/schema/latest/tei-epidoc.rng" schematypens="http://relaxng.org/ns/structure/1.0"?>'

and all the files still passed. I have added the declarations back in and they still pass. So the question: should Hook be checking to make sure these lines are there?

sonofmun commented 7 years ago

If the declarations are important to being able to use the files as we intend them to be used, then they should be tested.

PonteIneptique commented 7 years ago

I think this is closely related to #58 : we should ensure this can be done at some point. Either do --scheme auto,epidoc,tei. Epidoc would check for RNG declaration + run test, TEI same, auto would test the RNG listed :)

PonteIneptique commented 6 years ago

Closed by #130 ! Hurray !