Fix problem with get_cts_property

Capitains / MyCapytain

Texts API and Textual Resources Utility Library for Python 3

http://mycapytain.readthedocs.org

Mozilla Public License 2.0

8 stars 10 forks source link

Fix problem with get_cts_property #194

Closed sonofmun closed 5 years ago

sonofmun commented 5 years ago

See #193

coveralls commented 5 years ago

Coverage increased (+0.03%) to 93.989% when pulling 67eb4c97a0b4b132a6b1beb08ae87899606d7b2b on sonofmun-patch-1 into 1341291e9b841551cc715b47badeb19f6b2ae609 on dev.

sonofmun commented 5 years ago

Hmm. This errored because Travis errored while trying to install the requirements for Python 3.4.5. The problem is that LXML requires Python 3.5 or later. This means either 3.4.5 need to be removed from testing or LXML needs to be downgraded (probably the former). I can make this change in the yml file or the requirements.txt file once you let me know which should be changed.

sonofmun commented 5 years ago

And I guess I need to write a test for this as well. I will do that presently.

PonteIneptique commented 5 years ago

I'd remove 3.4.5 personnaly, but I'd like @balmas approval for this one

sonofmun commented 5 years ago

Coverage is your friend!

PonteIneptique commented 5 years ago

Gentle warning to @zfletch

zfletch commented 5 years ago

@PonteIneptique thanks for the heads up. Perseids is currently using Python 3.4, but all dependencies are locked, so this shouldn't immediately affect us. I'll make sure to update to 3.5 the next time I update Capitains.

PonteIneptique commented 5 years ago

;) Happy to be helpful