Capitalisk / ldpos-commander

CLI client for LDPoS blockchains
MIT License
3 stars 2 forks source link

Change VOTE TO DELEGATE SUCCESSFUL to POSTED VOTE or POSTED VOTE TRANSACTION #53

Closed jondubois closed 3 years ago

jondubois commented 3 years ago

Because the blockchain accepts all transactions (including invalid ones), we should change the wording so that it doesn't mislead the user. For example, if the user has already voted for 5 people, then the vote will do nothing.

jondubois commented 3 years ago

It's better to use more neutral wording throughout. The transaction is not a success until it's been added to a block and there is no guarantee until that time. For example, if the network is busy and the user offered fees which were too low, the transaction may not go through. It could just expire in the queue.

So it's better to say things like '... was posted' or '... was sent'.