search

CapnBry / HeaterMeter

HeaterMeter and LinkMeter Arduino BBQ Controller
https://tvwbb.com/forums/heatermeter-diy-bbq-controller.85/
MIT License
502 stars 83 forks source link

Temperature offset problem #3

Closed ioudeveldhuis closed 11 years ago

ioudeveldhuis commented 11 years ago

While testing a remote temperature node I found a bug, at least on my system. I was hoping that someone can confirm this.

My temperature reading from the remote probe gave a lower temperature then when reading from the fixed probe so I had to use the offset feature. When setting the offset (for me to +16), I saw that the temperature isn't displayed correctly. It starts with the correct temp, then adds another 16, then another 16 giving the most weird results. I started looking in the code and I think I found the problem. In grillpid.cpp, procedure void TempProbe::calcTemp(void). The offset is added in the if (hasTemperature()) section, I think this is incorrect. When I moved it to the setTemperatureC it displayed the correct temperature and kept on doing that ( setTemperatureC((T - 273.15f) + Offset); )

CapnBry commented 11 years ago

You're right, the offset adding should be done in setTemperatureC() so it only happens once per measurement rather than each loop. Fixed in c2b21d5

CapnBry commented 11 years ago

Included in latest push. Let me know if you still experience the issue.