search

CapnBry / HeaterMeter

HeaterMeter and LinkMeter Arduino BBQ Controller
https://tvwbb.com/forums/heatermeter-diy-bbq-controller.85/
MIT License
499 stars 83 forks source link

Misc build cleanups #51

Closed b0naf1de closed 4 years ago

b0naf1de commented 4 years ago

Various minor fixes to the installation to get a clean build

CapnBry commented 4 years ago

Hey thanks for these I will take a look at them over the weekend. Can you tell me what the brcmfmac43430-sdio.txt removal does though? It seems to not cause an issue or duplicate files, so I'd prefer to just leave it unless it is causing an issue.

b0naf1de commented 4 years ago

Np. All part of my effort to become more familiar with the openwrt build system.

When I clone the lede-project/source.git and move to branch 94491a15712732c56dccbf4593000376ae275134 I end up with a config file named brcmfmac43430-sdio.txt in openwrt/target/linux/brcm2708/base-files/lib/firmware/brcm . Part of the standard base-files.

Looks like this conflicts with a file that is installed from the firmware-brcmfmac43430 openwrt package. So my build bails on the clash.

Configuring uhttpd-mod-ubus.

Configuring kmod-spi-dev. Collected errors:

  • check_data_file_clashes: Package firmware-brcmfmac43430 wants to install file /home/eric/validate/openwrt/build_dir/target-arm_arm1176jzf-s+vfp_musl_eabi/root-brcm2708/lib/firmware/brcm/ brcmfmac43430-sdio.txt But that file is already provided by package * base-files
  • opkg_install_cmd: Cannot install package firmware-brcmfmac43430. package/Makefile:64: recipe for target 'package/install' failed make[2]: [package/install] Error 255 make[2]: Leaving directory '/home/eric/validate/openwrt' package/Makefile:106: recipe for target '/home/eric/validate/openwrt/staging_dir/target-arm_arm1176jzf-s+vfp_musl_eabi/stamp/.package_install' failed make[1]: [/home/eric/validate/openwrt/staging_dir/target-arm_arm1176jzf-s+vfp_musl_eabi/stamp/.package_install] Error 2 make[1]: Leaving directory '/home/eric/validate/openwrt' Build failed - please re-run with -j1 to see the real error message /home/eric/validate/openwrt/include/toplevel.mk:216: recipe for target 'world' failed make: *** [world] Error 1 eric@openwrt$

So, my non-elegant approach was to just remove base-files version one ... I believe I concluded the package contents were newer. If you're not seeing this then just ignore it.

Eric eric@thomasfam.com

On Fri, Mar 20, 2020 at 3:09 PM Bryan Mayland notifications@github.com wrote:

Hey thanks for these I will take a look at them over the weekend. Can you tell me what the brcmfmac43430-sdio.txt removal does though? It seems to not cause an issue or duplicate files, so I'd prefer to just leave it unless it is causing an issue.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CapnBry/HeaterMeter/pull/51#issuecomment-601889527, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIAHPPV4OA5HSSBZNXXBTETRIPEQFANCNFSM4LKD5WVA .

CapnBry commented 4 years ago

"This Weekend" usually means "next Thursday" right?

Merged, thanks for finding these things. The first one I already had locally but for some reason had been omitting from commits. I'm not sure why, but I've reverted mine and taken yours. Much appreciated.