CapnKitten / Material-Discord

Material design theme for Discord
336 stars 153 forks source link

[Guide/Issue] Font conflict when font already installed locally #165

Closed m-scha1337 closed 2 years ago

m-scha1337 commented 2 years ago

Right so.. I'm torn about whether i should even report this or not.. This "issue" is incredibly niche, will probably only ever affect a few dozen people or so and isn't actually an issue with the theme itself. But: When a font called "Google Sans" is already installed locally, the discord client will refer to using that font. However, for some odd reason, this will make some elements render as "Times New Roman" instead.

I have attached 2 screenshots of what i mean at the end of this post, but i already found 3(ish) solutions...

Solution 1) Uninstall fonts named "Google Sans" from the local machine. This would remove the font from the system though, meaning it cannot be used anywhere else on the system.

Solution 2) @CapnKitten: Modify the src attribute of every @font-face rule in google-sans.css to no longer consider local fonts called "Google Sans" (so removing local('Google Sans Regular'), local('GoogleSans-Regular'), as source). Solution 2b) Instead you could modify the font-family property of every @font-face rule in google-sans.css to something unique instead of "Google Sans" and rename the --app-font variable in source.css accordingly. (Not 100% certain that would work)

Solution 3) This one's kinda overkill but because i did not want to toss my local installation of google-sans, yet the theme seemingly demands characters not covered in my local installation, i downloaded all Google-Sans.woff2 fonts from https://capnkitten.github.io/BetterDiscord/Themes/Material-Discord/files/fonts/, converted them to .ttf and merged every variant (cyrillic, greek, latin and latinext) of every font weight, using font forge..


In any case.. This is probably all unnecessary.. You decide what happens, if anything happens at all.. Have a good one.


MaterialDiscordSerifIssue2 Please ignore the weirdly offset icon in the "Add to server" button. At first i thought this was related, when it probably is not MaterialDiscordSerifIssue1

CapnKitten commented 2 years ago

I removed the local fonts from the css file.