CappielloAntonio / tempo

An open source and lightweight music client for Subsonic, designed and built natively for Android.
GNU General Public License v3.0
867 stars 39 forks source link

[BUG] - Album art appears in notification player, but not in main player #113

Closed molohov closed 5 months ago

molohov commented 7 months ago

Describe the bug

Album art appears in the notification player, but not in the main player or the search results

Expected behavior

Album art should appear everywhere

To Reproduce

Play a song, observe the notification player vs the main player

Environment

Logs or Screenshots

Screen recording of the issue

Additional context

molohov commented 6 months ago

I resolved the issue of the album art not appearing in the main player by learning that Gonic does not fetch embedded album art. Adding album art into the music folder and then rescanning the library allows Tempo to see the album art.

However, I find it interesting that the notification player worked at all in the past. Was it fetching the embedded art somehow?

CappielloAntonio commented 6 months ago

Hello @molohov, does the file you're playing have the artwork embedded? Media3, the library I'm using, could be using that if the artwork uri is missing.

molohov commented 6 months ago

Correct, the art is embedded. Why doesn't it work in the main player though?

CappielloAntonio commented 6 months ago

Because everywhere, except for the notification, I manually create a mediaItem inside which, in addition to the various metadata, there is also the uri for the artwork (if it is present in the response given to me by the server). Evidently the notification makes do as best it can in case the mediaItem being played does not have the defined artwork, taking it from the stream.

molohov commented 6 months ago

I understand. So is there any possible fix?

CappielloAntonio commented 6 months ago

I don't think it's something that needs fixing. One option could be to not make the image visible in notifications neither when the server doesn't return the coverArt field, but I think in this unexpected situation it's not totally a bad thing.