search

CappielloAntonio / tempo

An open source and lightweight music client for Subsonic, designed and built natively for Android.
GNU General Public License v3.0
865 stars 39 forks source link

[BUG] - Shuffle button on artist page does not work #169

Open Eschguy opened 4 months ago

Eschguy commented 4 months ago

Describe the bug

Artist shuffle does nothing when pressed

Expected behavior

When on an artist page, pressing shuffle should make a shuffled playlist of all songs.

To Reproduce

  1. Pick any artist
  2. Click on Shuffle
  3. Nothing happens

Environment

Logs or Screenshots

Screenshot_20240211-121807.png

CappielloAntonio commented 4 months ago

Unfortunately I can't do much as the shuffle song list is given by the artist's Top Song. As we can see from your screenshot the list is absent.

The reason I don't shuffle all the artists' songs is because there is no API call that returns them all to me, but only one call to get the artist's albums, and from the albums individual calls for the songs inside. Which means a far higher number of calls than the one to get the top songs.

The most straightforward thing we can do is disable the shuffle button.

Eschguy commented 4 months ago

That's kind of a bummer, it'd be really nice to just run through an artist on shuffle.

NikMAX2077 commented 2 weeks ago

one call to get the artist's albums, and from the albums individual calls for the songs inside. Which means a far higher number of calls than the one to get the top songs.

It looks like Navidrome Web UI doing it, and it works fine. This would be a must have feature if Tempo would ever implement it too.