Request - Album artwork in Notification player

CappielloAntonio / tempo

An open source and lightweight music client for Subsonic, designed and built natively for Android.

GNU General Public License v3.0

871 stars 39 forks source link

Request - Album artwork in Notification player #49

Closed cirdanlunae closed 10 months ago

cirdanlunae commented 10 months ago

Having the artwork appear in the player in the Notification area would be a great addition for aesthetics.

This is the current behavior Screenshot_20230828-001044

This is the expected behavior (dSub, for example, does this, along with many "Major" streaming platforms) Screenshot_20230828-001428

CappielloAntonio commented 10 months ago

Hi @cirdanlunae, the cover art should be there. This is a video I made yesterday for another user, as you can see from the last few seconds of the video, the cover is where it should be.

https://github.com/CappielloAntonio/tempo/assets/14802539/95061a5d-1627-46bb-bce8-c030188d6b78

Could you please tell me which server you are using? Or if it's an offline track? Your situation usually occurs when the server is unreachable and therefore the cover art is not available.

sibwaf commented 10 months ago

Yup, also not working for me. Cover art is displayed in the app, but not in the notification.

Server: gonic Android: 13 (Samsung's OneUI) Tempo: 3.5.3 (the latest one)

Tempo

Subtracks

CappielloAntonio commented 10 months ago

Hi guys, may I ask you to try this test apk? It almost seems that the AOSP version of Android "knows" where to get the file artwork, while for all the others it must be specified.

app-notquitemy-debug.zip

sibwaf commented 10 months ago

Seems to be working only for files with embedded cover art. For albums that have the cover image as a separate file - same as before, displayed in the app, but not in the notification.

CappielloAntonio commented 10 months ago

Yes, sorry, I may have mistaken the id to use. Would you try this new release?

app-notquitemy-debug.zip

sibwaf commented 10 months ago

Yep, seems to be working fine now. Thanks!

CappielloAntonio commented 10 months ago

Thanks to you! I'm closing this issue, but if you have any problems, please feel free to reopen it.

cirdanlunae commented 10 months ago

Wow, I go to bed putting in the bug report, and I wake up to it fixed! Amazing--thank you!!!

That APK did the trick. My server/phone info just in case it's useful in case

Navidrome 0.49.3 Phone is running CalyxOS (up to date) Most recent Tempo apk

CappielloAntonio commented 10 months ago

I just wanted to point out that this apk has a different signature from the one released for all as it is the one intended for F-Droid. I'll be releasing a new release of the usual version soon, so you don't have two apps installed at the same time.