Open pingu7867 opened 1 year ago
This is actually a bunch of issues combined.
There's a bit more but this is roughly what happens. I guess the easiest solution - without reworking the whole argument thing - is to just set default values on every event so they always exist. I guess I can add that for the command event and we will see how that works.
Well, give it a try: https://github.com/CapsAdmin/pac3/archive/develop.zip It's only added for command events, everything else should still work as it did before. Let me know if it fixes the issue and I'll add it to the other events.
It breaks at a fundamental level.
-loading old outfits with the command events breaks the editor.
[pac3-develop] addons/pac3-develop/lua/pac3/core/client/parts/event.lua:830: attempt to concatenate local 'time' (a nil value)
Timer Failed! [pace_refresh_tree][@addons/pac3-develop/lua/pac3/editor/client/panels/tree.lua (line 569)]
https://user-images.githubusercontent.com/3782245/211098333-29120b1d-5d33-4af1-ba0a-53b53dbc9eb4.mp4 as a bonus, it almost guarantees that bug where some sort of label escapes the editor and ends up permanently in the top left corner (until a pac_restart)
-selecting the command event breaks the event, but starting from any other event name (even an invalid name i.e. misspelling the name) and then selecting command works "fine"
[pac3-develop] addons/pac3-develop/lua/pac3/core/client/parts/event.lua:830: attempt to concatenate local 'time' (a nil value)
[pac3-develop] addons/pac3-develop/lua/pac3/core/client/parts/event.lua:830: attempt to concatenate local 'time' (a nil value)
https://user-images.githubusercontent.com/3782245/211097335-114944fb-ecb3-46eb-9bf1-0fd534eb66d8.mp4
Ye I guess its because the time in your old outfits was never set. Could you try again? Same link: https://github.com/CapsAdmin/pac3/archive/develop.zip
it affects command's "hide in editor", ranger's "npcs and players only", etc. and affects both the workflow ingame and what eventually gets (not) saved if you miss it.
On closer inspection, the arguments aren't being registered in the editor unless of certain conditions. I've done some tests by doing actions at different orders.
the results of these orders of operations are as such.
https://user-images.githubusercontent.com/3782245/210969540-989a06a5-f590-463f-b1fc-43d910c7fd8b.mp4 video if that's any help.
with ranger, touching distance then checking the tickbox doesn't register the boolean and compare isn't registered either; touching compare registers both and allows the tickbox to be registered;
seems the boolean only gets registered if all number values, or the final/bottom number value in the list get registered / touched