CapsAdmin / pac3

advanced avatar customization for garrysmod
GNU General Public License v3.0
200 stars 93 forks source link

Previously fine outfit spews non-sensical warnings consistently #1359

Closed Earu closed 3 months ago

Earu commented 3 months ago

I get keep getting these warnings: Invalid model scale 0.000000 for class C_BaseFlex[-1] (x55)

I use the new model parts (not the legacy ones). The problem continues to happen until I remove every model part in the outfit.

TW1STaL1CKY commented 3 months ago

Can confirm - this is printed for each model part rendered on screen. It doesn't matter what the model part's size/scale is set to.

I should add that this is happening on the current x86-64 branch of gmod, just in case this isn't an issue on the main branch. There have been quite a few changes to the x86-64 branch lately so that is likely to have caused this to start happening.

DruCart3456 commented 3 months ago

Experimented with this for a bit, messing around. I can't confirm it, but I assumed at first it had to do with OBJs, as my pac only created this error when a set of generic spheres I grabbed from Blender I was using for eyes were loaded. Turning it into an MDL properly, it still created this error, but its the only model on my pac that does it.

However, after triangulating all faces in Blender rather than letting Crowbar do it automatically... this has seemingly fixed it. Will edit / delete this comment if it comes back up and the reason is not consistent, but it seems to be any models loaded that aren't triangulated before being compiled.

Asiliria commented 3 months ago

I've received constant complaints about this issue - I agree with DruCart, but at the same time, it still seems to occur even when all my OBJ parts are not loaded/fully removed. I'm leaning more towards the x86-64 branch changes that were mentioned introducing this bug, as the Linux build has been very active these past few months.

thegrb93 commented 3 months ago

https://github.com/CapsAdmin/pac3/blob/48743b7bd75c274cdc25c963387b98fa65ae0015/lua/pac3/core/client/parts/legacy/model.lua#L412

thegrb93 commented 3 months ago

https://github.com/CapsAdmin/pac3/blob/48743b7bd75c274cdc25c963387b98fa65ae0015/lua/pac3/core/client/owner_name.lua#L49

thegrb93 commented 3 months ago

https://github.com/CapsAdmin/pac3/blob/48743b7bd75c274cdc25c963387b98fa65ae0015/lua/pac3/core/client/parts/model.lua#L581

https://github.com/CapsAdmin/pac3/blob/48743b7bd75c274cdc25c963387b98fa65ae0015/lua/pac3/core/client/parts/model.lua#L441

thegrb93 commented 3 months ago

I'd complain to the gmod dev. Seems dumb for 0 to be an invalid scale.

Techbot121 commented 3 months ago

I think this error was added to prevent dividing by zero? but also you cannot go negative anymore well anyway I did push a fix for develop since it really is annoying.

see fb65d1b