Capstone-System-Miami / GithubTest

1 stars 2 forks source link

Create Cube Prefabs #26

Open softyay opened 2 months ago

softyay commented 2 months ago

Artists

Creating Cube Prefabs

softyay commented 2 months ago

@GustavoArismendi I'm going to revert the changes in your commit bc:

  1. Artists are making cubes, not Planes
  2. Your changes didn't include creating a material, so your prefab is showing up pink (no material)

If you could redo it, that would be great! Make sure to "pull changes" before you do 👍🏻

softyay commented 2 months ago

@MikasaAndRyuko I'm going to revert the changes in your commit bc:

  1. Artists are making cubes, not Planes

Instead of following exactly what I did in the video, can you redo it and put your prefab and material under "Artists"? Make sure to "pull changes" before you do 👍🏻

MikasaAndRyuko commented 2 months ago

I will get on that once I get home, thank you though.

On Sun, Sep 15, 2024 at 5:46 PM Layla H @.***> wrote:

@MikasaAndRyuko https://github.com/MikasaAndRyuko I'm going to revert the changes in your commit bc:

  1. Artists are making cubes, not Planes

Instead of following exactly what I did in the video, can you redo it and put your prefab and material under "Artists"? Make sure to "pull changes" before you do 👍🏻

— Reply to this email directly, view it on GitHub https://github.com/Capstone-System-Miami/GithubTest/issues/26#issuecomment-2351801911, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMXKKHOAJEUXZUPBAB4EBT3ZWX5ZVAVCNFSM6AAAAABN3U4RW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJRHAYDCOJRGE . You are receiving this because you were mentioned.Message ID: @.***>

OskarFinneran commented 2 months ago

I believe so I managed to complete the project I am just not sure how to check it

OskarFinneran commented 2 months ago

@MikasaAndRyuko I'm going to revert the changes in your commit bc:

  1. Artists are making cubes, not Planes

Instead of following exactly what I did in the video, can you redo it and put your prefab and material under "Artists"? Make sure to "pull changes" before you do 👍🏻

Ayyy so sorry i just saw this :( after pushing the changes so sorry

softyay commented 2 months ago

No worries! Instead of either of us reverting the commit, why don't you just move the prefab & mat to the appropriate folder and commit those changes!

softyay commented 2 months ago

Since you created them with unique names, it should be fine! When you move something from one folder to another, the way those changes are tracked is not as a modification to a single file. It treats it as if you: a) deleted the thing called "oskar mat" from producers folder, and b) created a new object called "oskat mat" in the artists folder! The only place you would run into trouble is if you were moving something to a folder where someone might have added something called "oskar mat" in the meantime. But that's why we're using our names, because theoretically nobody will be creating new objects with someone else's name!

MikasaAndRyuko commented 2 months ago

Just pulled, created a cube prefab, material, and pushed it.

On Sun, Sep 15, 2024 at 9:42 PM Layla H @.***> wrote:

Since you created them with unique names, it should be fine! When you move something from one folder to another, the way those changes are tracked is not as a modification to a single file. It treats it as if you: a) deleted the thing called "oskar mat" from producers folder, and b) created a new object called "oskat mat" in the artists folder! The only place you would run into trouble is if you were moving something to a folder where someone might have added something called "oskar mat" in the meantime. But that's why we're using our names, because theoretically nobody will be creating new objects with someone else's name!

— Reply to this email directly, view it on GitHub https://github.com/Capstone-System-Miami/GithubTest/issues/26#issuecomment-2351899414, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMXKKHJPSWR5AD2IZC4ZGILZWYZQPAVCNFSM6AAAAABN3U4RW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJRHA4TSNBRGQ . You are receiving this because you were mentioned.Message ID: @.***>