Captain-P-Goldfish / scim-for-keycloak

a third party module that extends keycloak by SCIM functionality
BSD 3-Clause "New" or "Revised" License
186 stars 48 forks source link

Add realm-management role for api access #11

Closed msiegenthaler closed 3 years ago

msiegenthaler commented 3 years ago

I wasn't completely happy with the approach from #10 (this PR replaces #10). While it works fine it has the danger that if the admin deletes the realm role the API would be unprotected again. This would be unexpected to the admin (at least to me).

So here's a new take:

The implementation isn't fully done yet, e.g. I've not yet tested the config UI or added tests (or fixed integration tests).

I like this approach better as it is less intrusive and it's harder for the admin to accidentally compromise security. What do you think?

Captain-P-Goldfish commented 3 years ago

I actually prefer #10. Adding this would be pretty much the same as what is already there. The only difference is that it is a client-role that is required now instead of a realm role. I can't see the actual benefit here. Besides the commit is incomplete see scrrenshot:

screen

Captain-P-Goldfish commented 3 years ago

I am going to close this one. I added some security considerations into the README.MD file