Captain-P-Goldfish / scim-for-keycloak

a third party module that extends keycloak by SCIM functionality
BSD 3-Clause "New" or "Revised" License
186 stars 48 forks source link

update liquibase schema location to use https for services that cannot handle redirects when parsing schema #40

Closed rudolficzek closed 2 years ago

rudolficzek commented 2 years ago

We encountering parse exception when trying to read scim-changelog.xml. dbchangelog-3.9.xsd has been moved permanently but our config doesnt handle redirects

using the https:// URL instead of http:// would permanently solve the problem

below the stack trace:

Error during startup: java.lang.RuntimeException: Exception invoking method [listUnrunChangeSets] on object [liquibase.Liquibase@1b4ec4ef], using arguments [null,(),false]

Caused by: liquibase.exception.ChangeLogParseException: Error parsing line 2 column 35 of META-INF/scim-changelog.xml: s4s-elt-character: Non-whitespace characters are not allowed in schema elements other than 'xs:appinfo' and 'xs:documentation'. Saw '301 Moved Permanently'.

Caused by: org.xml.sax.SAXParseException; systemId: http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.9.xsd; lineNumber: 2; columnNumber: 35; s4s-elt-character: Non-whitespace characters are not allowed in schema elements other than 'xs:appinfo' and 'xs:documentation'. Saw '301 Moved Permanently'.

Captain-P-Goldfish commented 2 years ago

merged pull request

Captain-P-Goldfish commented 2 years ago

I just noticed that the build does not work. I was a bit to hasty by merging it.

<databaseChangeLog xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
                   xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
                   xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog
                                                    https://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.9.xsd">

adding it like this would resolve the build-issue. Would this work in your case?

rudolficzek commented 2 years ago

thanks, this will do 👍