search

Captain-P-Goldfish / scim-for-keycloak

a third party module that extends keycloak by SCIM functionality
BSD 3-Clause "New" or "Revised" License
186 stars 48 forks source link

Case (in)sensitive PATCH operations #5

Closed petkocfc closed 3 years ago

petkocfc commented 3 years ago

Hi @Captain-P-Goldfish, we started using scim-for-keycloak version 1.8.2 on keycloak version 9.0. Everything worked fine until we started provisioning users over Azure SCIM where we have issue with case sensitive PATCH operations defined in PatchOp.

When users are patched over Azure SCIM operations have a first letter upper case (Add, Replace, Remove), and in the Azure documentation under "general guidelines" point six it's stated "Don't require a case-sensitive match on structural elements in SCIM, in particular PATCH op operation values, as defined in section 3.5.2. AAD emits the values of op as Add, Replace, and Remove."

This case sensitive check where problem lies is in PatchHandler - handlePatchOp.

Is it possible to make it case insensitive in PatchOp in order to be compatible with Azure SCIM?

Captain-P-Goldfish commented 3 years ago

Sorry for the late reply. I fixed it in the scim-sdk project. I think I am going to provide the new release at the beginning of april

petkocfc commented 3 years ago

Would it be too much of a trouble for you to release it sooner? Since we have a project relying on the fix that is due end of March 😅

Captain-P-Goldfish commented 3 years ago

I think I can do that. I will provide it until the end of next week then.

Captain-P-Goldfish commented 3 years ago

Release is out

kc-12-b2

petkocfc commented 3 years ago

Hi @Captain-P-Goldfish, just to say that we are constantly testing SCIM with Keycloak on Azure from the moment you released the new version and it's working smoothly.

Thank you.