Captain-P-Goldfish / scim-for-keycloak

a third party module that extends keycloak by SCIM functionality
BSD 3-Clause "New" or "Revised" License
183 stars 46 forks source link

Git release tags kc-12-b1 and kc-11-b1 point to the latest SNAPSHOT #6

Closed meden closed 3 years ago

meden commented 3 years ago

Hello, it seems that both release tags actually point to the same commit bumping the release to the next snapshot kc-12-b2 (3d6dca6).

They should point to respective release commit instead:

Thanks for your work, I'll hope to be able to test it soon!

Captain-P-Goldfish commented 3 years ago

thx for reporting this... seems I got a little slacky there. I am going to fix this later today

Captain-P-Goldfish commented 3 years ago

Okay I just managed to take a closer look. But the tags seem to be set correctly. Either that or I simply not getting the issue here. Could you please clarify for me?

If I checkout git checkout tags/kc-12-b1 I am landing on commit c452d75 just as you pointed out. And if I check in the commit histroy this is exactly the commit "Release to kc-12-b1"

meden commented 3 years ago

Well, I'm a little confused...

On GitHub: image

On my machine, right after a clone: image

And doing git checkout tags/kc-12-b1: image

(But I would just simply do git checkout -b kc-12-b1).

Am I missing something? Maybe you just did not push the tags on your machine?

Captain-P-Goldfish commented 3 years ago

I do not know how this happened. When I look at my local repository it looks like this: git-commands

But after a new checkout I can verify what you see. Big question is how this happened...

Captain-P-Goldfish commented 3 years ago

Okay the tags should be fixed now. Thanks. I would have never noticed this since my local setup was okay...