search

Captain-P-Goldfish / scim-for-keycloak

a third party module that extends keycloak by SCIM functionality
BSD 3-Clause "New" or "Revised" License
183 stars 47 forks source link

Bump keycloak-parent from 18.0.2 to 20.0.1 #70

Open dependabot[bot] opened 1 year ago

dependabot[bot] commented 1 year ago

Bumps keycloak-parent from 18.0.2 to 20.0.1.

Commits
  • cce8ee2 Set version to 20.0.1
  • 1ce6194 Upgrade Bouncycastle from 1.68 to 1.70 (#14198) (#15379)
  • 5843c81 Use RESOURCE_LOCAL transactions for JPA map storage (#15315)
  • 6bab737 Fix classpath separator for windows startup script (#15300) (#15377)
  • 717f656 Allow a partial import to overwrite the default role (#15316)
  • f698594 Close the session within resteasy boundaries (#15193)
  • 1711782 Remove AccountFormServiceTest (#15197)
  • 43a3677 Fix slow deletion on deleteClientSessionsByRealm and `deleteClientSessionsB...
  • 9fb9780 Don't rely on DefaultModeLCriteria in equals/hashCode
  • e494649 First naïve per-session caching for JPA map store
  • Additional commits viewable in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/Captain-P-Goldfish/scim-for-keycloak/network/alerts).
BradNut commented 1 year ago

@Captain-P-Goldfish Is this going to be merged to the master branch so tags get updated for the more recent versions of Keycloak like 20.0.1?

Will the "scim" theme be automatically updated to be more inline with the Keycloak 20.0.1 version?

Captain-P-Goldfish commented 1 year ago

Hi, The plugin is compatible with kc 19 and 20. The problem is that the Theme is still bound to the old web administration console. The new keycloak ui that is developed in react does not have this kind of extensiability yet. A ticket was opened regarding this issue in the keycloak-ui project.

BradNut commented 1 year ago

Hey @Captain-P-Goldfish. Thank you for responding. Yes I saw that when I built with the latest tag and added the jar to the providers folder on Keycloak 20.0.1 it creates the scim role etc.

I am also able to see the theme change and once changing to this I can see the SCIM entry in the left hand panel with the ability to turn SCIM on and off.

Two questions then:

  1. If I perform SCIM related Realm Configuration changes here I assume they will persist if I decide I want to go back to the default version 20 UI look and feel? I ask because I have plans to update and utilize the React front-end of the new version and do not wish to rely on the old UI day to day tasks.
  2. Can you provide a link here regarding the issue that was raised in the keycloak-ui project for tracking purposes and so I can follow up there?

Thank you!

EDIT: After installing the plugin JAR, changing the theme, and then enabling SCIM configs I was no longer able to change the theme back to the new Keycloak 20+ React theme. @Captain-P-Goldfish is this because using the scim config overrides the new theme?

Captain-P-Goldfish commented 1 year ago

Hi,

  1. The configuration changes are made within the database, so yes the theme itself has nothing to do with the SCIM endpoints being enabled or disabled and you should be able to freely switch between the themes without any restrictions of the functionality.
  2. I saw, that you already found the issue in the project: https://github.com/keycloak/keycloak/issues/17769

And at last. I cannot verify the behaviour you are describing. If I setup kc-20 with the plugin and change the theme, activate the SCIM endpoint and change the theme back everything works as expected. In my case the theme is back to the react based version.

dependabot[bot] commented 1 year ago

A newer version of org.keycloak:keycloak-parent exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.