search

Captain-P-Goldfish / scim-for-keycloak

a third party module that extends keycloak by SCIM functionality
BSD 3-Clause "New" or "Revised" License
186 stars 48 forks source link

Feature Request: make isHotDeploying configurable #82

Closed davidmc24 closed 1 year ago

davidmc24 commented 1 year ago

Thanks again for the project. It's working nicely.

We have a process where we run all our Keycloak database migrations as a standalone process prior to starting up the "real" Keycloak. While doing so, we were sometimes encountering race conditions that appeared to be related to RealmRoleInitializer running its initialization logic when it wasn't expected. After some investigation, it seems that our migrator process was being considered a "hot deploy". Would it be possible to make this explicitly configurable, rather than detecting solely based on presence of a particular component in JNDI? We currently have a workaround that puts a stub JNDI in place, but would like to be able to remove the workaround at some point.

https://github.com/Captain-P-Goldfish/scim-for-keycloak/blob/master/scim-for-keycloak-server/src/main/java/de/captaingoldfish/scim/sdk/keycloak/provider/RealmRoleInitializer.java#L91

Captain-P-Goldfish commented 1 year ago

Hi I am going to release the SCIM for keycloak enterprise project soon. This problem is fixed in this version.

davidmc24 commented 1 year ago

Great! Thanks for the reply.