search

Captain-P-Goldfish / scim-for-keycloak

a third party module that extends keycloak by SCIM functionality
BSD 3-Clause "New" or "Revised" License
183 stars 46 forks source link

Deactivate SCIM by default #9

Closed msiegenthaler closed 3 years ago

msiegenthaler commented 3 years ago

This PR deactivates SCIM on new realms by default and prevents that SCIM is automatically active on all realm after installing the extension. This ensures that the administrator doesn't activate SCIM by accident, since it might be "invisible" when the admin theme is not changed.

msiegenthaler commented 3 years ago

argh, sorry, need to rebase :)

Captain-P-Goldfish commented 3 years ago

An additiional note in the README.MD would be great that mentions that the endpoints are disabled by default

msiegenthaler commented 3 years ago

added a note

Captain-P-Goldfish commented 3 years ago

Just checked and found one little problem. See screen.

If an admin creates a new realm and SCIM is disabled the endpoints are not accessed and thus the resource-types are not created in the database. So when pressing the resource-types tab we get a "Resource Not Found" page.

screen

Captain-P-Goldfish commented 3 years ago

But I guess this is actually my own error isn't it? :-)

Captain-P-Goldfish commented 3 years ago

Hi do you still plan to fix the integration-tests on this?

msiegenthaler commented 3 years ago

Jup, just got „delayed“ by the patch of good weather lately 😀