search

CaptainCodeman / svelte-headlessui

HeadlessUI components for Svelte
https://captaincodeman.github.io/svelte-headlessui/
MIT License
539 stars 26 forks source link

Rename pkg.main to pkg.module #29

Closed lachlancollins closed 1 year ago

lachlancollins commented 1 year ago

I recently discovered publint, and I've been using it to test svelte libraries as I was working on @tanstack/svelte-query. I noticed that it gave one suggestion for this package: https://publint.dev/svelte-headlessui

Since svelte-headlessui builds for ESM (as it should), it should use "module": "dist/index.js" instead of "main": "./dist/index.js". This probably isn't breaking anything for most people as I'm pretty sure node will read "exports" over "main", but best to fix it just in case.

CaptainCodeman commented 1 year ago

Thanks, I must have seen the same tweet or wherever it was mentioned 'cause I just came across it too and ran in on some packages including this one. I was still in "do I need to do this?" mode, LOL