search

CaptainDreamcast / DolmexicaInfinite

Something resembling a Mugen port for Dreamcast.
MIT License
24 stars 5 forks source link

Update stage.cpp #2

Open Mike77154 opened 4 years ago

Mike77154 commented 4 years ago

Midi features nostalgic adding

CaptainDreamcast commented 4 years ago

Thanks for the proposed contribution! There are some questions I still have about it.

I understand that it's a MIDI library, but I don't understand what including it in stage.cpp does, if it's not used anywhere. In addition to that, I don't know what "tsf.h" is, is it a local file of yours? It would no longer compile for me if I added that include.

As a general structure note, I tend to not include external libraries in Dolmexica directly, but rather wrap them in my wrapper library, prism. That's because Dreamcast/Windows/Web tend to have different requirements regarding external libraries and I'd like to keep those kind of things out of Dolmexica.

I know Mugen supports MIDI audio and I still plan to add it in the future, I have just started working on sound effects again during demo 12 and I still want to keep working on them. I'll make a note of that and would try adding MIDI stuff for demo 13 (march 6th) if you would be ok with it.