search

CaptainGinyu / RobotFilmmaker

1 stars 0 forks source link

Code Review (SivaTejaswi Irkm) #6

Closed SivaTejaswiIrkm closed 6 years ago

SivaTejaswiIrkm commented 6 years ago
  1. It is difficult to understand the project without an updated readme file.
  2. cloudtraining.py file contains some code that has been commented. I understand the project is still under development but there is a way to retrieve deleted lines of code from git without having to comment them and keep it in your code.
  3. servosTest.ino is very clearly named and written and is easy to understand.
  4. Not very sure how to build the code and see the implementation.
philyuan commented 6 years ago

We added some software dependencies to the readme. Thanks for the advice!