search

CaptainKeqing / pe

0 stars 0 forks source link

Edit not allowing change of person ID limits valid changes #8

Open CaptainKeqing opened 6 months ago

CaptainKeqing commented 6 months ago

Problem

Edit does not allow one to change role or ID.

However, it is highly possible that a person's ID may have been keyed in wrongly before, and after adding multiple tags which take alot of work since they have to be added manually, we would have to delete the person and redo all these.

image.png

Recommended Solution

Allowing editing of ID, since limiting it does not benefit the user.

nus-pe-bot commented 6 months ago

Team's Response

It is a deliberate design choice as the contact entry is uniquely identified by their ID and it can cause cascading issues if we allow edits of unique identifier for each contact entry.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The team rejected my bug issue by saying it is a deliberate design choice.

This I understand, but what I'm reporting is that it is a BAD design choice, thus FeatureFlaw.

As mentioned in my initial bug report, limited ID change creates a troublesome situation for the user of the app (head TAs).

It is highly possible that a person's ID may have been keyed in wrongly before, and after adding multiple tags which take alot of work since they have to be added manually, we would have to delete the person and redo all these.

Thus, I stand by my opinion that it should be a FeatureFlaw