search

CaptainKeqing / ped

0 stars 0 forks source link

Index parsing disregards leading zeros #1

Open CaptainKeqing opened 5 months ago

CaptainKeqing commented 5 months ago

Problem

The INDEX parse checks do not account for leading zeroes.

If I type 000001 (or any amount of leading zeroes) it deletes the 1th index for both delete and deleteOrder. This applies to any index that is present in the list.

Pre-execution

image.png

After executing delete 000000001

image.png

Then, execute deleteOrder 001

image.png

Recommended Fix

Perhaps it would be better to add checks to account for this. Something simple would be trimming leading zeroes because these will definitely not be a valid index !

rertyy commented 5 months ago

Hi @CaptainKeqing

The way you phrase this issue seems to indicate that there is no problem regarding the current implementation, can I confirm that this is your intention?

Separately, we will include the fact that leading 0's will be stripped within the UG.