CaptainKeqing / ped

0 stars 0 forks source link

User Guide for editOrder says at least one optional field must be specified, but feature works without. #5

Open CaptainKeqing opened 7 months ago

CaptainKeqing commented 7 months ago

Problem

The User Guide and the functionality of the code do not match up. While the User Guide specifies that one or more optional fields need to be present, the feature in the code works without it.

From the User Guide

image.png

Executing editOrder 1

Command executes with no error, and no changes made.

image.png

Recommended Fix

1) Perhaps it would be good to use the similar checks that EditCommand used to see if any of it's fields are edited, otherwise it rejects the command. 2) Alternatively, if you want the command to work without any optional fields specified, it is a good idea to remove this line from the UG.