search

Captricity / mocurly

Mocurly is a library that mocks the recurly python client
MIT License
8 stars 6 forks source link

Update billinginfo + Add reactivate support #2

Closed niekbaeten closed 8 years ago

niekbaeten commented 8 years ago

This fixes a bug where after creating an account without billing info, the account would throw an exception on update_billing_info.

yorinasub17 commented 8 years ago

Thanks for your contribution! This looks good. Can you provide a unit test for this specific scenario? I'll merge it once that's implemented.

You can ignore the broken coupon redemption test caused by https://github.com/Captricity/mocurly/issues/3

yorinasub17 commented 8 years ago

The additional contribution also looks good except for the error check. I'll merge once the last nit is addressed. Ping me with a comment when you push the error check!

Really appreciate your contribution!

niekbaeten commented 8 years ago

Good point, I implemented the extra check and extended the test for it. Sorry about the mixup this feature should've gone in a separate branch.

yorinasub17 commented 8 years ago

Looks good! Thanks!