CarVac / filmulator-gui

Filmulator --- Simplified raw editing with the power of film
https://filmulator.org
Other
669 stars 31 forks source link

Desktop file invalid #129

Closed hfiguiere closed 3 years ago

hfiguiere commented 3 years ago

This exec line in the desktop file is:

Exec=cd/usr/lib/filmulator-gui && /usr/lib/filmulator-gui/filmulator-gui

Many problems:

https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s07.html

I'd submit a patch, but the CMake system link an executable filmulator that is installed in $PREFIX/bin (that's good), but is inconsistent with the qmake build system. So the matters are a bit more complicated.

hfiguiere commented 3 years ago

The warnings by flatpak-builder (as it runs desktop-file-validate)

WARNING: Failed to validate desktop file /home/hub/source/org.filmulator.Filmulator/repo/export/share/applications/org.filmulator.Filmulator.desktop: /home/hub/source/org.filmulator.Filmulator/repo/export/share/applications/org.filmulator.Filmulator.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated
/home/hub/source/org.filmulator.Filmulator/repo/export/share/applications/org.filmulator.Filmulator.desktop: error: value "cd/usr/lib/filmulator-gui && /usr/lib/filmulator-gui/filmulator-gui" for key "Exec" in group "Desktop Entry" contains a reserved character '&' outside of a quote
/home/hub/source/org.filmulator.Filmulator/repo/export/share/applications/org.filmulator.Filmulator.desktop: error: value "cd/usr/lib/filmulator-gui && /usr/lib/filmulator-gui/filmulator-gui" for key "Exec" in group "Desktop Entry" contains a reserved character '&' outside of a quote

WARNING: Binary not found for Exec line in /home/hub/source/org.filmulator.Filmulator/repo/export/share/applications/org.filmulator.Filmulator.desktop: cd/usr/lib/filmulator-gui && /usr/lib/filmulator-gui/filmulator-gui
CarVac commented 3 years ago

I'd rather make this compatible with cmake.