search

CarVac / filmulator-gui

Filmulator --- Simplified raw editing with the power of film
https://filmulator.org
Other
671 stars 32 forks source link

import button does nothing #142

Open anarcat opened 3 years ago

anarcat commented 3 years ago

I tried to import pictures from ~/Photos/2021 in my home directory, and the "import" button did nothing whatsoever. Maybe it's because the files are symlinked (managed by git-annex) or under some sub-sub directory? directory structure is like ~/Photos/YYYY/MM/DD/NAME/...

installed through flathub.

thanks!

CarVac commented 3 years ago

It currently doesn't follow symlinks.

I was afraid of infinite recursion when I wrote the import routine, but I guess I should work on something more robust that will follow them but track if it has followed that symlink before.

anarcat commented 3 years ago

On 2021-04-04 12:09:45, CarVac wrote:

It currently doesn't follow symlinks.

I was afraid of infinite recursion when I wrote the import routine, but I guess I should work on something more robust that will follow them but track if it has followed that symlink before.

I would argue that people who create infinite recursions get what they desserve. Maybe an option flag?

-- Perl is "some assembly required". Python is "batteries included". PHP is "kitchen sink, but it’s from Canada and both faucets are labeled C".

CarVac commented 3 years ago

Maybe I'll just set a recursion depth limit of something reasonable, like 20. Would that be enough for your use case? Are all subdirectories in git-annex symbolic links?

anarcat commented 3 years ago

On 2021-04-05 15:25:34, CarVac wrote:

Maybe I'll just set a recursion depth limit of something reasonable, like 20. Would that be enough for your use case? Are all subdirectories in git-annex symbolic links?

Only the files are symlinks, not directories.

CarVac commented 3 years ago

Ah, this will take another round of tweaking then (I made it follow folder symlinks to a limited recursion depth).

anarcat commented 3 years ago

On 2021-04-06 06:08:50, CarVac wrote:

Ah, this will take another round of tweaking then (I made it follow folder symlinks to a limited recursion depth).

I would really not worry about following symlinks at all, personnally. Just follow them: if it breaks, it's garbage in, garbage out.

-- "Faith" means not wanting to know what is true.

CarVac commented 3 years ago

Could you test the v0.11.2rc1 AppImage from here?

https://discuss.pixls.us/t/filmulator-nightly-builds-now-for-windows-and-linux/12838

Also, I believe it should have worked already if you imported individual files instead of a whole directory.

anarcat commented 3 years ago

Could you test the v0.11.2rc1 AppImage from here?

i'm a little hesitant in running arbitrary code without a sandbox from the web... it's why i like using the flathub thing. ;) could the RCs be pushed to flathub as well?

CarVac commented 3 years ago

You can firejail appimages if you want.