search

CarVac / filmulator-gui

Filmulator --- Simplified raw editing with the power of film
https://filmulator.org
Other
669 stars 31 forks source link

Pregenerated PNG icon is non-square #147

Closed danfe closed 2 years ago

danfe commented 2 years ago

The resources/filmulator64icon.png file has size 64x58 which Qt (tested with 5.15.2 but may affect any version) apparently does not accept as a valid icon, so the call to window->setIcon(QIcon(...)) in main.cpp is useless. Converting (or using instead of PNG) original SVG file to proper 64x64 sized icon fixes the problem.

CarVac commented 2 years ago

Huh, I didn't consider that the original SVG might work; I'll test that on the platforms I have available.

The non-square PNG works on Linux and Windows, for what it's worth.

CarVac commented 2 years ago

SVG works on my Linux machine, and plays slightly better with the KDE taskbar than the PNG did. I'll test the Windows build after work.

danfe commented 2 years ago

Huh, I didn't consider that the original SVG might work

Qt documentation states that it has SVG support in the icon engine since Qt 4.2.

CarVac commented 2 years ago

The SVG change works on both Windows and Linux, so I'm considering this issue fixed.

What platform were you having the issue on, btw?

danfe commented 2 years ago

What platform were you having the issue on, btw?

I'm on FreeBSD/amd64. Since you've added the .svg icon to resources/pixmaps.qrc, shouldn't the .png version be removed to trim 4KB off the executable size?

CarVac commented 2 years ago

Good idea, done.

CarVac commented 2 years ago

Hm, this broke the Linux AppImage icon. I didn't expect that to be different from the locally built one...