search

CarVac / filmulator-gui

Filmulator --- Simplified raw editing with the power of film
https://filmulator.org
Other
672 stars 32 forks source link

macstack maintenence for AppleClang 10 #75

Closed Benitoite closed 5 years ago

Benitoite commented 5 years ago

My new build system is with AppleClang 10 on macOS 10.14 Mojave, a side-grade from the clang++-mp-3.9 I was using before on 10.12 Sierra, requiring a couple of changes.

The qmlfile changes in main.cpp I had made earlier on the Sierra builds, which allow the program to launch.

Benitoite commented 5 years ago

Also note the travis yml is a linux build script.

CarVac commented 5 years ago

So it looks like these need to be gated to only happen for Mac, because it caused the CI build to fail on Linux. I'll see if I can get it working on Linux and then you'll have to try it on Mac again.

Benitoite commented 5 years ago

Thanks for having a look at that, CarVac. I just didn't realize i was trampling over the linux compilation. Another thing i had to do was search and replace "10.14" with "10.9" (i still need to d/l the 10.10 sdk, which is technically correct for Qt5.9) in the resulting Makefile for backwards compatibility, but i couldnt find any codified places where a change would solve that. I tried many thing in the .pro file, but nothing im aware of yet can sway qmake from using the "10.14" sdk. For native own-machine builds that doesnt really matter anyway, and i can use a sed command to handle that for the build instructions. I wonder if qmake will let me sed the Makefile after it builds.

CarVac commented 5 years ago

Try out this branch to see if it fits your needs. I've added some platform specific stuff in the makefile and ifdefs in main.cpp.

https://github.com/CarVac/filmulator-gui/tree/macstackpatch