CarVac / filmulator-gui

Filmulator --- Simplified raw editing with the power of film
https://filmulator.org
Other
670 stars 32 forks source link

Windows builds #86

Closed heckflosse closed 4 years ago

heckflosse commented 5 years ago

Currently there are no Windows builds available for Filmulator. Let's work together to build Filmulator on Windows and also to make build instructions which are easy to follow.

gaaned92 commented 5 years ago

first question: should we use qmake or cmake?

CarVac commented 5 years ago

Use cmake. There's... a lot more documentation out there for it.

gaaned92 commented 5 years ago

Branch highlightrecovery Using cmake in a mingw64 shell

...
[100%] Linking CXX executable filmulator.exe
[100%] Built target filmulator
MAKE INSTALL
[  2%] Automatic MOC for target filmulator
[  2%] Built target filmulator_autogen
[100%] Built target filmulator
Install the project...
-- Install configuration: "release"
-- Installing: D:/PROGRAMMES/Filmulator/fminstall/bin/filmulator.exe
...

Then it finishes after

-- Installing: D:/PROGRAMMES/Filmulator/fminstall/share/Filmulator/qml/filmulator-gui/gui_components/ToolRadioButtonStyle.qml
gaaned92 commented 5 years ago

Then copying these dependencies I can start the application. I didn' test. I will be back home in 3 days.

list="libgomp-1.dll          libwinpthread-1.dll
     libjpeg-8.dll  libjasper-4.dll    libexiv2.dll
          liblcms2-2.dll      libpcre-1.dll libpcre2-16-0.dll
   libbz2-1.dll              
  libexpat-1.dll libiconv-2.dll libharfbuzz-0.dll
libfreetype-6.dll  libgraphite2.dll libicuin*.dll     libpng16-16.dll    zlib1.dll
libgcc_s_seh-1.dll  libicuuc*.dll     libraw_r-*.dll libtiff-5.dll
liblzma-5.dll  libicudt*.dll
libglib-2.0-0.dll   libintl-8.dll   librtprocess.dll   libstdc++-6.dll libjpeg-8.dll
libzstd.dll
 QT5Network.dll
qt5core.dll qt5gui.dll qt5qml.dll qt5quick.dll qt5sql.dll qt5widgets.dll"
echo "$list"
robocopy /MINGW64/bin "$destination"/bin $list

robocopy /MINGW64/share/qt5/plugins/platforms "$destination/platforms" qdirect2d.dll qminimal.dll qoffscreen.dll qwebgl.dll qwindows.dll

Sure, the list of dependencies has to be cleaned!

I cannot build other branches this way.

gaaned92 commented 5 years ago

Filmulator_highlightrecovery_v0.7.0-120-g857d12a_release_64.zip

uploaded at https://keybase.pub/gaaned92/Filmulator

Benitoite commented 5 years ago

@gaaned92 Testing on win8:

7597691E-9E10-469E-B020-7E4C1B9BB194

gaaned92 commented 5 years ago

@Benitoite perhaps the platforms subdir is not located at the right place?

On starting on W10 I get these messages

APPDIR: (null)
dbSetup old version: 10
loading ui from datadir
D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-120-g857d12a_release_64/share/Filmulator/qml/filmulator-gui/main.qml
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-120-g857d12a_release_64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value"
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-120-g857d12a_release_64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value"
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-120-g857d12a_release_64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value"
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-120-g857d12a_release_64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value"
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-120-g857d12a_release_64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value"
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-120-g857d12a_release_64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value"
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-120-g857d12a_release_64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value"
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-120-g857d12a_release_64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value"
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-120-g857d12a_release_64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value"
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-120-g857d12a_release_64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value"
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-120-g857d12a_release_64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value"
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-120-g857d12a_release_64/share/Filmulator/qml/filmulator-gui/gui_components/ImportDirEntry.qml:61:17: Unable to assign [undefined] to QEasingCurve
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-120-g857d12a_release_64/share/Filmulator/qml/filmulator-gui/gui_components/ImportDirEntry.qml:67:17: Unable to assign [undefined] to QEasingCurve
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-120-g857d12a_release_64/share/Filmulator/qml/filmulator-gui/gui_components/ImportFileEntry.qml:62:17: Unable to assign [undefined] to QEasingCurve
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-120-g857d12a_release_64/share/Filmulator/qml/filmulator-gui/gui_components/ImportFileEntry.qml:68:17: Unable to assign [undefined] to QEasingCurve
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-120-g857d12a_release_64/share/Filmulator/qml/filmulator-gui/gui_components/ImportDirEntry.qml:61:17: Unable to assign [undefined] to QEasingCurve
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-120-g857d12a_release_64/share/Filmulator/qml/filmulator-gui/gui_components/ImportDirEntry.qml:67:17: Unable to assign [undefined] to QEasingCurve
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-120-g857d12a_release_64/share/Filmulator/qml/filmulator-gui/gui_components/ImportDirEntry.qml:61:17: Unable to assign [undefined] to QEasingCurve
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-120-g857d12a_release_64/share/Filmulator/qml/filmulator-gui/gui_components/ImportDirEntry.qml:67:17: Unable to assign [undefined] to QEasingCurve
heckflosse commented 5 years ago

I managed to build and install filmulator on Windows 7. But, with my own build and also with @gaaned92 build the only thing I get when starting filmulator.exe is:

APPDIR: (null)
dbSetup old version: 10
QML UI file missing

Edit: I did a fresh install of msys2 to test the build process.

heckflosse commented 5 years ago

With latest code from highlightrecovery branch, I now get this when building on Windows:

$ cmake -G "MSYS Makefiles" -DCMAKE_BUILD_TYPE="Debug" ..
-- The CXX compiler identification is GNU 9.1.0
-- Check for working CXX compiler: C:/msys64/mingw64/bin/g++.exe
-- Check for working CXX compiler: C:/msys64/mingw64/bin/g++.exe -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at C:/msys64/mingw64/share/cmake-3.14/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
  Could NOT find Exiv2: Found unsuitable version "..", but required is at
  least "0.25" (found C:/msys64/mingw64/include)
Call Stack (most recent call first):
  C:/msys64/mingw64/share/cmake-3.14/Modules/FindPackageHandleStandardArgs.cmake:376 (_FPHSA_FAILURE_MESSAGE)
  cmake/Modules/FindExiv2.cmake:76 (find_package_handle_standard_args)
  CMakeLists.txt:27 (find_package)

-- Configuring incomplete, errors occurred!
See also "Z:/H2/filmulator/filmulator-gui/build/CMakeFiles/CMakeOutput.log".

Edit: with the changes from this patch it builds fine

gaaned92 commented 5 years ago

W10, Filmulator_highlightrecovery_v0.7.0-132-gee93410_debug_64 can be downloaded at https://keybase.pub/gaaned92/Filmulator

APPDIR: (null)
dbSetup old version: 10
loading ui from datadir
D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-132-gee93410_debug_64/share/Filmulator/qml/filmulator-gui/main.qml
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-132-gee93410_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value"
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-132-gee93410_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value"
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-132-gee93410_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value"
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-132-gee93410_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value"
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-132-gee93410_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value"
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-132-gee93410_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value"
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-132-gee93410_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value"
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-132-gee93410_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value"
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-132-gee93410_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value"
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-132-gee93410_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value"
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-132-gee93410_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value"
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-132-gee93410_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ImportDirEntry.qml:61:17: Unable to assign [undefined] to QEasingCurve
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-132-gee93410_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ImportDirEntry.qml:67:17: Unable to assign [undefined] to QEasingCurve
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-132-gee93410_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ImportFileEntry.qml:62:17: Unable to assign [undefined] to QEasingCurve
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-132-gee93410_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ImportFileEntry.qml:68:17: Unable to assign [undefined] to QEasingCurve
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-132-gee93410_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ImportDirEntry.qml:61:17: Unable to assign [undefined] to QEasingCurve
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-132-gee93410_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ImportDirEntry.qml:67:17: Unable to assign [undefined] to QEasingCurve
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-132-gee93410_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ImportDirEntry.qml:61:17: Unable to assign [undefined] to QEasingCurve
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-132-gee93410_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ImportDirEntry.qml:67:17: Unable to assign [undefined] to QEasingCurve

click onImport files click on Select files : a selection window opens, I select a NEF photo. a curious name appears : file:///D:/PHOTOS/test2/20170626_0028.NEF click on Import in place click on import ** Correct the errors appears . hovering on file name, Choose a valid file appears.

The file is a quite valid NEF file.

gaaned92 commented 5 years ago

Question to a QT5 and cmake guru.

When building a debug build, the debug versions of the QT5 dll are required (QT5Networkd.dll qt5cored.dll qt5guid.dll qt5qmld.dll qt5quickd.dll qt5sqld.dll qt5widgetsd.dll). Its about 1,5 GO! As we are not going to debug QT5 I suppose, how it is possible to link in a debug build the normal versions of the QT5 dlls (QT5Network.dll qt5core.dll qt5gui.dll qt5qml.dll qt5quick.dll qt5sql.dll qt5widgets.dll) ?

Benitoite commented 5 years ago

@gaaned92 Do a string(REPLACE d.dll .dll ${releaselibs} ${debuglibs}) on the appropriate output and input vars.

CarVac commented 5 years ago

The errors on startup are normal, unfortunately.

I tried Filmulator_highlightrecovery_v0.7.0-132-gee93410_debug_64 on my Windows laptop and it didn't work, saying

This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: direct2d, minimal, offscreen, webgl, windows.

Additionally, I added some debug print statements to find out why the file has been rejected, so please build it again and tell me what the terminal outputs after you click on Import.

gaaned92 commented 5 years ago

@CarVac I tried Filmulator_highlightrecovery_v0.7.0-132-gee93410_debug_64 on my Windows laptop and it didn't work, saying Either the /platforms QT subdir is wrongly located or for a debug build it should contain the debug versions of the dlls! I am surprised it works on my PC as QT is NOT in the windows PATH variable. So I suppose it is hardcoded. Going to google.

@Benitoite Thanks for the tip, but I fear I am not proficient enough to apply it :confused: Could you give me a more detailed procedure?

CarVac commented 5 years ago

@gaaned92 Could you try rebuilding with the latest version and trying to import a file again?

I'd like to see the terminal output you get after clicking Import.

Benitoite commented 5 years ago

@gaaned92 I get the no Qt platform plugin could be initialized error too on mac if the following is not set by the executable loader script: export QT_QPA_PLATFORM_PLUGIN_PATH=../../plugins/platforms

Unfortunately I'm not setup ATM to experiment in win cmake. On mac, doing a debug build doesn't set, for example, Qt5::QtCore to point to QtCore_debug by the config, it points to the non-debug QtCore symlink.

Briefest primer on string(REPLACE old new output input)

Using Qt5::Core as an example, I can find out where it's pointing with:

get_target_property(xyz Qt5::Core LOCATION)
message(${xyz})

Let's say when printing xyz, cmake output /path/to/qt5cored.dll Then we can:

string(REPLACE d.dll .dll xyz ${xyz})
message(${xyz})

and get the output: /path/to/qt5core.dll

gaaned92 commented 5 years ago

@CarVac Filmulator_highlightrecovery_v0.7.0-144-ged927b7_debug_64

APPDIR: (null)
dbSetup old version: 10
loading ui from datadir
D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-144-ged927b7_debug_64/share/Filmulator/qml/filmulator-gui/main.qml
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-144-ged927b7_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value"
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-144-ged927b7_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value"
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-144-ged927b7_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value"
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-144-ged927b7_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value"
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-144-ged927b7_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value"
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-144-ged927b7_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value"
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-144-ged927b7_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value"
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-144-ged927b7_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value"
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-144-ged927b7_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value"
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-144-ged927b7_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value"
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-144-ged927b7_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value"
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
QSqlQuery::value: not positioned on a valid record
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-144-ged927b7_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ImportDirEntry.qml:61:17: Unable to assign [undefined] to QEasingCurve
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-144-ged927b7_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ImportDirEntry.qml:67:17: Unable to assign [undefined] to QEasingCurve
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-144-ged927b7_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ImportFileEntry.qml:62:17: Unable to assign [undefined] to QEasingCurve
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-144-ged927b7_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ImportFileEntry.qml:68:17: Unable to assign [undefined] to QEasingCurve
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-144-ged927b7_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ImportDirEntry.qml:61:17: Unable to assign [undefined] to QEasingCurve
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-144-ged927b7_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ImportDirEntry.qml:67:17: Unable to assign [undefined] to QEasingCurve
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-144-ged927b7_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ImportDirEntry.qml:61:17: Unable to assign [undefined] to QEasingCurve
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-144-ged927b7_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/ImportDirEntry.qml:67:17: Unable to assign [undefined] to QEasingCurve
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-144-ged927b7_debug_64/share/Filmulator/qml/filmulator-gui/Edit.qml:1839:17: Unable to assign [undefined] to bool
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-144-ged927b7_debug_64/share/Filmulator/qml/filmulator-gui/Edit.qml:1845:21: Unable to assign [undefined] to QEasingCurve
file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-144-ged927b7_debug_64/share/Filmulator/qml/filmulator-gui/Edit.qml:1851:21: Unable to assign [undefined] to QEasingCurve
Model size of -149 is less than 0
Model size of -13 is less than 0
File not found: file:///D:/PHOTOS/test2/20170626_0028.NEF
Count: 7

Edit: if I suppress file:/// in the file name before importing, Filmulator doesn't complain but nothing appears in the window. I get this message

file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-144-ged927b7_debug_64/share/Filmulator/qml/filmulator-gui/gui_components/QueueDelegate.qml:70:13: QML Image: Le protocole "c" est inconnu
Model size of -149 is less than 0
Model size of -13 is less than 0
gaaned92 commented 5 years ago

@Benitoite I begin to understand that making a bundled installation file for an application using QT is not straightforward and needs a knowledge of the QT development environment that I don't have.

So I am going to limit myself to build and test on the my machine without providing installer. In that case, the needed QT resources seem accessible thanks to hardcoded paths.

In the same time, I will try to understand how to deploy on windows, hoping that a proficient dev will set up the procedure.

gaaned92 commented 5 years ago

I think I am not far from being able to generate a bundled deployment build. Could you try and test: https://keybase.pub/gaaned92/Filmulator/Filmulator_highlightrecovery_v0.7.0-144-ged927b7_release_64.zip

Benitoite commented 5 years ago

@gaaned92 Capture and then exit on windows 8.1/64

gaaned92 commented 5 years ago

To reproduce

Why it starts? The QML path is hardcoded somewhere with the absolute initial installation path: file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-144-ged927b7_release_64/share/Filmulator/qml/filmulator-gui and this installtion is still present.

In my bash script I do:

$pushd $INSTALLDIR/bin
$/c/msys64/mingw64/bin/windeployqt.exe --"$BUILD_TYPE" --qmldir ../share/Filmulator/qml/filmulator-gui filmulator.exe
$popd

So, I provide a relative path to filmulator.exe.

Help!

CarVac commented 5 years ago

If there is a good relative path between the executable and the QML that I can add, let me know.

I'll try this tonight.

gaaned92 commented 5 years ago

@CarVac In my script a relative path to QML ( see above) :../share/Filmulator/qml/filmulator-gui, is provided to windeployqt.exe.

Can you code the above relative path?

mermerico commented 5 years ago

By the way, this is not a permanent solution, but for testing purposes, if the current directory is $INSTALL\share\Filmulator\, then I am able to run @gaaned92's executable.

CarVac commented 5 years ago

@gaaned92 Could you make a new build based on this? I've done a bunch of fixes to the QML that I was able to test, but I need it recompiled to test the C++ fixes.

I didn't make any changes to the qml directory location yet.

gaaned92 commented 5 years ago

@mermerico Not very satisfactory :worried:

@CarVac Filmulator_highlightrecovery_v0.7.0-158-gd96063b_release_Windows64.zip

APPDIR: (null) dbSetup old version: 10 loading ui from datadir D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-158-gd96063b_release_Windows64/share/Filmulator/qml/filmulator-gui/main.qml home directory: C:/Users/Andre/AppData/Local/filmulator/thumbs file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-158-gd96063b_release_Windows64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value" QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-158-gd96063b_release_Windows64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value" QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-158-gd96063b_release_Windows64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value" QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-158-gd96063b_release_Windows64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value" QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-158-gd96063b_release_Windows64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value" QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-158-gd96063b_release_Windows64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value" QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-158-gd96063b_release_Windows64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value" QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-158-gd96063b_release_Windows64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value" QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-158-gd96063b_release_Windows64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value" QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-158-gd96063b_release_Windows64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value" QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-158-gd96063b_release_Windows64/share/Filmulator/qml/filmulator-gui/gui_components/ToolSlider.qml:93:5: QML SlipperySlider: Binding loop detected for property "value" QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record QSqlQuery::value: not positioned on a valid record file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-158-gd96063b_release_Windows64/share/Filmulator/qml/filmulator-gui/gui_components/QueueDelegate.qml:70:13: QML Image: Cannot open: file://c/Users/Andre/AppData/Local/filmulator/thumbs/f45e/f45e80515f321f369199c259c9d5fa820001.jpg file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-158-gd96063b_release_Windows64/share/Filmulator/qml/filmulator-gui/gui_components/ImportDirEntry.qml:61:17: Unable to assign [undefined] to QEasingCurve file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-158-gd96063b_release_Windows64/share/Filmulator/qml/filmulator-gui/gui_components/ImportDirEntry.qml:67:17: Unable to assign [undefined] to QEasingCurve file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-158-gd96063b_release_Windows64/share/Filmulator/qml/filmulator-gui/gui_components/ImportFileEntry.qml:62:17: Unable to assign [undefined] to QEasingCurve file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-158-gd96063b_release_Windows64/share/Filmulator/qml/filmulator-gui/gui_components/ImportFileEntry.qml:68:17: Unable to assign [undefined] to QEasingCurve file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-158-gd96063b_release_Windows64/share/Filmulator/qml/filmulator-gui/gui_components/ImportDirEntry.qml:61:17: Unable to assign [undefined] to QEasingCurve file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-158-gd96063b_release_Windows64/share/Filmulator/qml/filmulator-gui/gui_components/ImportDirEntry.qml:67:17: Unable to assign [undefined] to QEasingCurve file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-158-gd96063b_release_Windows64/share/Filmulator/qml/filmulator-gui/gui_components/ImportDirEntry.qml:61:17: Unable to assign [undefined] to QEasingCurve file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-158-gd96063b_release_Windows64/share/Filmulator/qml/filmulator-gui/gui_components/ImportDirEntry.qml:67:17: Unable to assign [undefined] to QEasingCurve file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-158-gd96063b_release_Windows64/share/Filmulator/qml/filmulator-gui/Edit.qml:1839:17: Unable to assign [undefined] to bool file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-158-gd96063b_release_Windows64/share/Filmulator/qml/filmulator-gui/Edit.qml:1845:21: Unable to assign [undefined] to QEasingCurve file:///D:/PROGRAMMES/Filmulator/fminstall/Filmulator_highlightrecovery_v0.7.0-158-gd96063b_release_Windows64/share/Filmulator/qml/filmulator-gui/Edit.qml:1851:21: Unable to assign [undefined] to QEasingCurve Model size of -155 is less than 0 Model size of -14 is less than 0 Model size of -2 is less than 0 Model size of -14 is less than 0 QSqlQuery::value: not positioned on a valid record importWorker no replace, doesn't exist camToRGB: 1.91254 -1.05866 0.146114 camToRGB: -0.224857 1.64658 -0.421722 camToRGB: 0.00986511 -0.509289 1.49942 camToRGB: 1.91254 -1.05866 0.146114 camToRGB: -0.224857 1.64658 -0.421722 camToRGB: 0.00986511 -0.509289 1.49942 camToRGB4: 1 0 0 0 camToRGB4: 0 1 0 1 camToRGB4: 0 0 1 0 BLACKPOINT 2047 color channel blackpoints 0 0 0 0 block-based blackpoint dimensions: 0 0 block-based blackpoint: WHITE SATURATION ======================================================== data_maximum: 0 maximum: 15490 fmaximum: 0 fnorm: 0 xtrans: 000000 xtrans: 000000 xtrans: 000000 xtrans: 000000 xtrans: 000000 xtrans: 000000 max of raw_image: 5459 =============================================== min of raw_image: 60 imagePipeline.cpp: Opening D:/PHOTOS/test2/IMG_3756.CR2 load start:0.647269 raw width: 5496 raw height: 3670 load time: 2.42851 ImagePipeline::processImage: Demosaic complete. scale start:3.07849 scale end: 0.326127 hlrecovery start:3.40489 hlrecovery end: 0.002992 rmult: 0.999992 gmult: 1 bmult: 1 rCamMul: 1.85547 gCamMul: 1 bCamMul: 1.77441 ImagePipeline::processImage: Prefilmulation complete. ImagePipeline::processImage: Filmulation complete. home directory: C:/Users/Andre/AppData/Local/filmulator/thumbs Warning: Exif tag Exif.Photo.MakerNote not encoded Warning: Exif tag Exif.Canon.0x4002 not encoded Warning: Exif tag Exif.Canon.0x4005 not encoded importFile SearchID: 15fe2b4cf99fe364112f58bd1111f2740001

There is no error now, but nothing appears and I don't know how to continue.

Benitoite commented 5 years ago

On the mac due to its bundle structure, I ran into some similar loading issues. What I did was use the following executable loader: https://github.com/CarVac/filmulator-gui/blob/d96063b5ba5b1a2dd8807f8c47566d1efd9e1100/filmulator-gui/resources/macos/filmulator-gui#L4-L10 and modifiedmain.cpp https://github.com/CarVac/filmulator-gui/blob/d96063b5ba5b1a2dd8807f8c47566d1efd9e1100/filmulator-gui/main.cpp#L105-L107 main.cpp contains the assignment of the installation prefix appdir from environmental APPDIR, which is rooted two directories above the executable binary on mac. ../.. https://github.com/CarVac/filmulator-gui/blob/d96063b5ba5b1a2dd8807f8c47566d1efd9e1100/filmulator-gui/main.cpp#L33-L35 Since your APPDIR is null, the log indicates you went thru https://github.com/CarVac/filmulator-gui/blob/d96063b5ba5b1a2dd8807f8c47566d1efd9e1100/filmulator-gui/main.cpp#L125-L130 but ultimately https://github.com/CarVac/filmulator-gui/blob/d96063b5ba5b1a2dd8807f8c47566d1efd9e1100/filmulator-gui/ConfigureChecks.cmake#L1 I found going the APPDIR route was more flexible in allowing a relative path.

CarVac commented 5 years ago

@gaaned92 Could you post the build?

It looks like everything worked but you needed to either have enabled Enqueue Imported Photos or afterwards you need to go to the Organize tab, find the photos, double-click them, and then double-click one of them in the queue to select it for editing in the Filmulate tab.

gaaned92 commented 5 years ago

@CarVac last build systematically posted at https://keybase.pub/gaaned92/Filmulator

CarVac commented 5 years ago

Hmm, thumbnails are still broken, but if you double-click in the empty space where the first image should be enqueued it loads in the Filmulate tab.

I know what's wrong, but I need to figure out how to fix it...

CarVac commented 5 years ago

And... it should be fixed.

With this, everything seems to be working fine with one exception: the (invisible) resize handle on the splitviews is WAY TOO FAT, so I can't select the earliest (leftmost) days in the Date Histogram at the top of the Organize tab.

Not sure why it's so huge in Windows. @Benitoite is this a problem on Mac?

CarVac commented 5 years ago

I made a change so that it looks for the qml directory in the same place as where the executable is.

Benitoite commented 5 years ago

So, when I copy the share/Filmulator/qml dir to the bin dir it launches (no thumbnails) Capture .

Benitoite commented 5 years ago

@CarVac resizers look normal sized to me on Win 8 and macOS 10.15

CarVac commented 5 years ago

There evidently haven't been any new builds yet, which is why thumbnails are still broken.

gaaned92 commented 5 years ago

Filmulator_highlightrecovery_v0.7.0-160-g6666c4b_release_Windows64.zip uploaded

Edit1: I get those messages : file:///D:/PROGRAMMES/Filmulator/Filmulator_highlightrecovery_v0.7.0-160-g6666c4b_release_Windows64/bin/qml/filmulator-gui/gui_components/OrganizeDelegate.qml:45:9: QML Image: Cannot open: file://c/Users/Andre/b656/b6560dedca9153620b7bf9b08fcc2f620001.jpg

Edit2:

CarVac commented 5 years ago

I don't see anything in https://keybase.pub/gaaned92/Filmulator/

My thumbnails were going in AppData\Local (file:///C:/Users/carvac/AppData/Local/filmulator/thumbs/e464/e46436e05c0795810855fa5cdd2554750001.jpg for example). I'll have to figure out why yours were not.

Where are the files actually?

heckflosse commented 5 years ago

I don't see anything in https://keybase.pub/gaaned92/Filmulator/

I see this: grafik

gaaned92 commented 5 years ago
CarVac commented 5 years ago

In hindsight, of course it didn't work.

I pushed two more changes; can you please rebuild it?

Thanks.

gaaned92 commented 5 years ago

Filmulator_highlightrecovery_v0.7.0-162-g9f6e796_release_Windows64.zip uploaded

imagePipeline.cpp: Opening D:/PHOTOS/test2/20170626_0028.NEF
load start:0.5984
raw width:  6016
raw height: 4016
load time: 2.90025
ImagePipeline::processImage: Demosaic complete.
scale start:3.49964
scale end: 0.397936
hlrecovery start:3.89758
hlrecovery end: 0.002992
rmult: 1
gmult: 1
bmult: 0.999992
rCamMul: 2.21094
gCamMul: 1
bCamMul: 1.57422
ImagePipeline::processImage: Prefilmulation complete.
ImagePipeline::processImage: Filmulation complete.
dirstring: /C:/Users/Andre/AppData/Local/filmulator/thumbs
Thumbnail being written to: C:/Users/Andre/f45e/f45e80515f321f369199c259c9d5fa820001
Warning: Exif tag Exif.NikonPreview.JPEGInterchangeFormatLength not encoded
Warning: Exif IFD NikonPreview not encoded
Warning: Exif tag Exif.Photo.MakerNote not encoded
Warning: Exif tag Exif.NikonSi02xx.0x027a not encoded
Warning: Exif tag Exif.Nikon3.0x00bc not encoded
importFile SearchID: f45e80515f321f369199c259c9d5fa820001
dirstring: /C:/Users/Andre/AppData/Local/filmulator/thumbs
file:///D:/PROGRAMMES/Filmulator/Filmulator_highlightrecovery_v0.7.0-162-g9f6e796_release_Windows64/bin/qml/filmulator-gui/gui_components/OrganizeDelegate.qml:45:9: QML Image: Cannot open: file:///C:/Users/Andre/AppData/Local/filmulator/thumbs/f45e/f45e80515f321f369199c259c9d5fa820001.jpg
CarVac commented 5 years ago

I see the problem now.

I was changing the thumbnail directory for everything, not just for the QML, so it ended up writing the thumbnail to the wrong location and reading from the right location.

It should be fixed in https://github.com/CarVac/filmulator-gui/commit/469f46f6a5c9e1b883fc525191608bbb8bfd08b6.

gaaned92 commented 5 years ago

Filmulator_highlightrecovery_v0.7.0-163-g469f46f_release_Windows64.zip uploaded

-when importing files, the thumbnail don't appear directly in the film strip at the bottom of the window. I have to go in the organize tab. I don't know if it is normal.

CarVac commented 5 years ago

Screenshot_20190612_082151

If you have "Enqueue imported photos" turned on, then it will appear directly in the work queue at the bottom when you import.

It should be possible to put the qml directory in the right location. I'll have to do research and/or experimentation to figure out how to do that.

Would you be able to make a little writeup of your build process (how do you get the dependencies built/installed)? I'm very unfamiliar with building software on Windows.

CarVac commented 5 years ago

@gaaned92

https://github.com/CarVac/filmulator-gui/commit/f6157498ed65d28701be145e78b0069dbbbed425 should put the QML directory in the right place, like you wanted.

gaaned92 commented 5 years ago

Filmulator_highlightrecovery_v0.7.0-165-gf615749_release_Windows64.zip

uploaded at https://keybase.pub/gaaned92/Filmulator

@CarVac I am writing in markdown a little guide for building on Windows.

@heckflosse @Benitoite @mermerico @aferrero2707 and other windows users, could you test the build please?

heckflosse commented 5 years ago

@gaaned92 Your build works fine here \o/

CarVac commented 5 years ago

The build works fine for me as well.

The grab handle issue is really irksome, though; it makes it so at 1.0 UI scale, you can't reach the saturation slider, and there's only one row of pixels where you can access the export button between the splitview resize handles.

I'm going to have to reimplement SplitView for consistent behavior.

CarVac commented 5 years ago

Turns out the SplitView issue is triggered whenever the device is (correctly or incorrectly) detected to have a touchscreen: on these the SplitView drag handle is designed to be 7mm wide, which is absurdly too fat for a mouse-driven interface.

So I just took the SplitView code and removed that functionality.

heckflosse commented 5 years ago

@gaaned92 Maybe interesting for your builds: https://github.com/CarVac/librtprocess/issues/43