search

CarVac / filmulator-gui

Filmulator --- Simplified raw editing with the power of film
https://filmulator.org
Other
670 stars 32 forks source link

Fix exiv2 detection #94

Closed cryptomilk closed 5 years ago

cryptomilk commented 5 years ago

Fixes #87

CarVac commented 5 years ago

Hmm, this doesn't actually work for me. I poked into the exiv2 header files and found the following:

version.hpp exists, so it reads the contents into EXIV2_VERSION_CONTENT.
It reads this and finds EXIV2_MAJOR_VERSION, and thus setting EXIV2_MAJOR_FOUND > 0.
That's true, so it sets EXIV2_VERSION_STRING_FOUND.

However, from that point, it reads in exv_conf.h and tries to read major, minor, and patch versions from that. But exv_conf.h doesn't have the major, minor, and patch versions listed separately, it has the version listed straight up under EXV_PACKAGE_VERSION as 0.25, missing the patch number.

Instead it should be reading these in from version.hpp.

cryptomilk commented 5 years ago

In line 62 there is a NOT missing

if (NOT ...

CarVac commented 5 years ago

Fixed.