search

CarVac / librtprocess

A project to make RawTherapee's processing algorithms more readily available.
Other
53 stars 24 forks source link

Port new ca correction code from rt as soon as it is in dev branch of rt #11

Closed heckflosse closed 6 years ago

heckflosse commented 6 years ago

Todo for 1.0

heckflosse commented 6 years ago

@CarVac @aferrero2707

To port the new ca correction code from rt I need to include the gauss code (two source files) as well. I can do that in a way that it is just used internally in raw ca correction without exposing the gauss interface, but I can also do that with exposing the gauss interface. The latter would mean, the highly optimized gauss functions from rt would be also available for projects which use librtprocess.

What do you prefer?

CarVac commented 6 years ago

Gauss functions as in gaussian blur?

heckflosse commented 6 years ago

@CarVac Yes, exactly this file https://github.com/Beep6581/RawTherapee/blob/dev/rtengine/gauss.h and also this https://github.com/Beep6581/RawTherapee/blob/dev/rtengine/gauss.cc

CarVac commented 6 years ago

I'm fine with exposing functionality.

aferrero2707 commented 6 years ago

I'm also quite interested in the Gauss blur code.

heckflosse commented 6 years ago

see https://github.com/CarVac/librtprocess/pull/13