Open CarVac opened 5 years ago
@heckflosse I already proposed a solution for the callback over at PIXLS. Maybe that got lost over the C vs. C++ dispute.
Is that all we need to to for a C API?
What about extern "C"
?
bool
is C99 and requires #include <stdbool.h>
.
HTH, Flössie
There's one more thing I'd like to add:
I'm a well-known friend of const
and use it almost everywhere. This almost excludes places where const
makes no sense. And one such place is a top-level const
on a parameter in a function declaration. clang-tidy
will even remove it when asked for, by the way.
For some details see here.
Best, Flössie
I created a merge request with a C API wrapper
The current interface is:
So we need to get rid of the
const std::function
, the#include <functional>
and the default values for CA_correct.Is that all we need to to for a C API?